Issue 6303079: storing, indexing of branches

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6303079: storing, indexing of branches

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 10 months ago by breton

Modified:
12 years, 10 months ago

Reviewers:
thomas.j.waldmann, Reimar Bauer

Visibility:
Public.

More Reviews

Patch Set 1 #

Total comments: 8

Created: 12 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+85 lines, -13 lines)			Patch
	M	MoinMoin/storage/backends/_tests/test_stores.py	View		2 chunks	+17 lines, -2 lines	3 comments	Download
	M	MoinMoin/storage/backends/stores.py	View		7 chunks	+68 lines, -11 lines	5 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

ThomasJWaldmann

http://codereview.appspot.com/6303079/diff/1/MoinMoin/storage/backends/_tests/test_stores.py File MoinMoin/storage/backends/_tests/test_stores.py (right): http://codereview.appspot.com/6303079/diff/1/MoinMoin/storage/backends/_tests/test_stores.py#newcode59 MoinMoin/storage/backends/_tests/test_stores.py:59: uh_store) hmm, that isn't far fetched from what we ...

12 years, 10 months ago (2012-06-17 12:30:08 UTC) #1

breton

+ IRC. http://codereview.appspot.com/6303079/diff/1/MoinMoin/storage/backends/stores.py File MoinMoin/storage/backends/stores.py (right): http://codereview.appspot.com/6303079/diff/1/MoinMoin/storage/backends/stores.py#newcode123 MoinMoin/storage/backends/stores.py:123: def _get_user(self, userid): On 2012/06/17 12:30:08, ThomasJWaldmann ...

12 years, 10 months ago (2012-06-17 14:25:42 UTC) #2

Reimar Bauer

12 years, 10 months ago (2012-06-19 06:32:35 UTC) #3

some comments

http://codereview.appspot.com/6303079/diff/1/MoinMoin/storage/backends/_tests...
File MoinMoin/storage/backends/_tests/test_stores.py (right):

http://codereview.appspot.com/6303079/diff/1/MoinMoin/storage/backends/_tests...
MoinMoin/storage/backends/_tests/test_stores.py:51: os.rmdir(branches_path)
that makes file I/O, can we avoid that

Also the tmp path should be in the scope of the instance

http://codereview.appspot.com/6303079/diff/1/MoinMoin/storage/backends/_tests...
MoinMoin/storage/backends/_tests/test_stores.py:55: os.rmdir(uh_path)
this makes also file I/O

Expand All Messages | Collapse All Messages