Issues warning for negative-spanning line spanner.

Issues warning for negative-spanning line spanner.

[Keith, 2012-06-20 05:31:50]

http://codereview.appspot.com/6302097/diff/1/lily/line-spanner.cc
File lily/line-spanner.cc (right):

http://codereview.appspot.com/6302097/diff/1/lily/line-spanner.cc#newcode373
lily/line-spanner.cc:373: me->warning (_ ("Line spanner's left point is to the
right of its right point."));
if 'me' supports me->origin()->warning()
it will tell the user which line spanner(s)

[MikeSol, 2012-06-20 06:57:37]

Thanks for the review!

http://codereview.appspot.com/6302097/diff/1/lily/line-spanner.cc
File lily/line-spanner.cc (right):

http://codereview.appspot.com/6302097/diff/1/lily/line-spanner.cc#newcode373
lily/line-spanner.cc:373: me->warning (_ ("Line spanner's left point is to the
right of its right point."));
On 2012/06/20 05:31:50, Keith wrote:
> if 'me' supports me->origin()->warning()
> it will tell the user which line spanner(s)

::origin is only defined for stream events, music, context defs and books.

[dak, 2012-06-20 07:18:41]

http://codereview.appspot.com/6302097/diff/1/lily/line-spanner.cc
File lily/line-spanner.cc (right):

http://codereview.appspot.com/6302097/diff/1/lily/line-spanner.cc#newcode373
lily/line-spanner.cc:373: me->warning (_ ("Line spanner's left point is to the
right of its right point."));
On 2012/06/20 06:57:38, MikeSol wrote:
> On 2012/06/20 05:31:50, Keith wrote:
> > if 'me' supports me->origin()->warning()
> > it will tell the user which line spanner(s)
> 
> ::origin is only defined for stream events, music, context defs and books.

Double "uh what?!?" here.  The whole point of me->warning _is_ to deliver a
source correlation for me if available by traversing the grob cause chain until
finding a music or stream event with recognizable origin.

The code already _does_ deliver the origin info when somehow available.  That is
the sole point of having a Grob::warning in the first place.

[Keith, 2012-06-20 23:27:26]

Works good for me.

(I was obviously confused earlier about which warning() was being called.)