Issue 6302092: Fixed compile warning in SkOSWindow_unix.cpp

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6302092: Fixed compile warning in SkOSWindow_unix.cpp

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 4 months ago by kondapallykalyan

Modified:
12 years, 4 months ago

Reviewers:
bsalomon, scroggo

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Fixed following compile time warning: ../src/views/unix/SkOSWindow_Unix.cpp: In member function ‘void SkOSWindow::loop()’: ../src/views/unix/SkOSWindow_Unix.cpp:184:33: warning: ‘KeySym XKeycodeToKeysym(Display*, KeyCode, int)’ is deprecated (declared at /usr/include/X11/Xlib.h:1695) [-Wdeprecated-declarations] ../src/views/unix/SkOSWindow_Unix.cpp:184:74: warning: ‘KeySym XKeycodeToKeysym(Display*, KeyCode, int)’ is deprecated (declared at /usr/include/X11/Xlib.h:1695) [-Wdeprecated-declarations] ../src/views/unix/SkOSWindow_Unix.cpp:199:47: warning: ‘KeySym XKeycodeToKeysym(Display*, KeyCode, int)’ is deprecated (declared at /usr/include/X11/Xlib.h:1695) [-Wdeprecated-declarations] ../src/views/unix/SkOSWindow_Unix.cpp:199:88: warning: ‘KeySym XKeycodeToKeysym(Display*, KeyCode, int)’ is deprecated (declared at /usr/include/X11/Xlib.h:1695) [-Wdeprecated-declarations] XKeycodeToKeysym is marked as deprecated (https://bugs.freedesktop.org/show_bug.cgi?id=5349). Another related bug: https://bugs.freedesktop.org/show_bug.cgi?id=25732#c4 which suggests to use XkbKeycodeToKeySym instead of this one. Similar issue was fixed in chromium http://code.google.com/p/chromium/issues/detail?id=117274

Patch Set 1 #

Created: 12 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
	M	src/views/unix/SkOSWindow_Unix.cpp	View		3 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

LGTM, committed as r4278

Expand All Messages | Collapse All Messages