Issue 6301084: Added support for pre-defined macros.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6301084: Added support for pre-defined macros. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 2 months ago by Alok Priyadarshi

Modified:
13 years, 2 months ago

Reviewers:
kbr1

CC:
angleproject-review_googlegroups.com

Base URL:
http://angleproject.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Added support for pre-defined macros. Committed: https://code.google.com/p/angleproject/source/detail?r=1157

Patch Set 2 : #

Total comments: 2

Created: 13 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+246 lines, -11 lines)			Patch
M	src/compiler/preprocessor/new/Diagnostics.h	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/compiler/preprocessor/new/DirectiveParser.cpp	View	1	3 chunks	+27 lines, -7 lines	0 comments	Download
M	src/compiler/preprocessor/new/Macro.h	View	1	1 chunk	+3 lines, -1 line	0 comments	Download
M	src/compiler/preprocessor/new/MacroExpander.cpp	View	1	3 chunks	+24 lines, -2 lines	2 comments	Download
M	src/compiler/preprocessor/new/Preprocessor.h	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/compiler/preprocessor/new/Preprocessor.cpp	View	1	2 chunks	+28 lines, -0 lines	0 comments	Download
M	tests/preprocessor_tests/define_test.cpp	View	1	3 chunks	+138 lines, -0 lines	0 comments	Download
M	tests/preprocessor_tests/location_test.cpp	View	1	2 chunks	+22 lines, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

kbr1

LGTM http://codereview.appspot.com/6301084/diff/2001/src/compiler/preprocessor/new/MacroExpander.cpp File src/compiler/preprocessor/new/MacroExpander.cpp (right): http://codereview.appspot.com/6301084/diff/2001/src/compiler/preprocessor/new/MacroExpander.cpp#newcode192 src/compiler/preprocessor/new/MacroExpander.cpp:192: static const std::string kFile = "__FILE__"; These won't ...

13 years, 2 months ago (2012-06-19 17:57:24 UTC) #2

Alok Priyadarshi

13 years, 2 months ago (2012-06-19 18:15:36 UTC) #3

http://codereview.appspot.com/6301084/diff/2001/src/compiler/preprocessor/new...
File src/compiler/preprocessor/new/MacroExpander.cpp (right):

http://codereview.appspot.com/6301084/diff/2001/src/compiler/preprocessor/new...
src/compiler/preprocessor/new/MacroExpander.cpp:192: static const std::string
kFile = "__FILE__";
On 2012/06/19 17:57:24, kbr1 wrote:
> These won't introduce static initializers into the binary, will they?

Don't know how those work. If we run into that issue while rolling angle rev, I
will just remove these variables temporarily. Eventually I plan to introduce the
notion of keywords in addition to identifiers, which will get rid of these
string comparisons.

Expand All Messages | Collapse All Messages