Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1309)
Issues Repositories Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 6300114: Expand distribution of instance counting (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 5 months ago by robertphillips
Modified:
12 years, 5 months ago
Reviewers:
bsalomon, reed1
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

A lot of simple changes.

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+138 lines, -5 lines) Patch
M bench/RefCntBench.cpp View 1 chunk +7 lines, -0 lines 0 comments Download
M bench/SkBenchmark.h View 2 chunks +4 lines, -0 lines 0 comments Download
M bench/SkBenchmark.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M include/core/SkAdvancedTypefaceMetrics.h View 2 chunks +5 lines, -0 lines 0 comments Download
M include/core/SkBitmap.h View 2 chunks +4 lines, -0 lines 0 comments Download
M include/core/SkBounder.h View 1 chunk +2 lines, -0 lines 0 comments Download
M include/core/SkCanvas.h View 2 chunks +4 lines, -0 lines 0 comments Download
M include/core/SkData.h View 2 chunks +4 lines, -0 lines 0 comments Download
M include/core/SkDevice.h View 2 chunks +4 lines, -0 lines 0 comments Download
M include/core/SkDeviceProfile.h View 2 chunks +4 lines, -0 lines 0 comments Download
M include/core/SkDrawFilter.h View 1 chunk +3 lines, -0 lines 0 comments Download
M include/core/SkFlattenable.h View 2 chunks +4 lines, -0 lines 0 comments Download
M include/core/SkInstCnt.h View 2 chunks +6 lines, -5 lines 1 comment Download
M include/core/SkPicture.h View 2 chunks +4 lines, -0 lines 0 comments Download
M include/core/SkPtrRecorder.h View 1 chunk +2 lines, -0 lines 0 comments Download
M include/core/SkStream.h View 2 chunks +5 lines, -0 lines 0 comments Download
M include/core/SkWeakRefCnt.h View 1 chunk +2 lines, -0 lines 0 comments Download
M include/gpu/GrCustomStage.h View 1 chunk +2 lines, -0 lines 0 comments Download
M include/gpu/gl/GrGLInterface.h View 1 chunk +4 lines, -0 lines 0 comments Download
M include/gpu/gl/SkGLContext.h View 2 chunks +4 lines, -0 lines 0 comments Download
M include/images/SkImageDecoder.h View 3 chunks +14 lines, -0 lines 0 comments Download
M include/images/SkMovie.h View 2 chunks +4 lines, -0 lines 0 comments Download
M include/text/SkTextLayout.h View 2 chunks +4 lines, -0 lines 0 comments Download
M src/core/SkAdvancedTypefaceMetrics.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M src/core/SkBitmap.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M src/core/SkCanvas.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M src/core/SkData.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M src/core/SkDevice.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M src/core/SkDeviceProfile.cpp View 2 chunks +8 lines, -0 lines 0 comments Download
M src/core/SkFlattenable.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M src/core/SkPicture.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M src/core/SkPtrRecorder.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M src/core/SkStream.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M src/gpu/GrCustomStage.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M src/gpu/gl/GrGLInterface.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M src/gpu/gl/SkGLContext.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M src/images/SkImageDecoder.cpp View 1 chunk +4 lines, -0 lines 0 comments Download
M src/images/SkMovie.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M src/text/SkTextLayout.cpp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 4
robertphillips
http://codereview.appspot.com/6300114/diff/1/include/core/SkInstCnt.h File include/core/SkInstCnt.h (right): http://codereview.appspot.com/6300114/diff/1/include/core/SkInstCnt.h#newcode55 include/core/SkInstCnt.h:55: \ This just makes the printout a bit nicer ...
12 years, 5 months ago (2012-06-19 17:34:28 UTC) #1
bsalomon
LGTM but reed@ should approve adding inst counting to the core classes.
12 years, 5 months ago (2012-06-19 17:49:02 UTC) #2
reed1
might consider an opt-out (or opt-in) flag to control this separately from SK_DEBUG/SK_RELEASE ... but ...
12 years, 5 months ago (2012-06-19 18:01:44 UTC) #3
robertphillips
12 years, 5 months ago (2012-06-21 20:26:29 UTC) #4 
committed as r4291
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b