Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2608)

Issue 6300079: Deletes logfiles in build dir with make clean (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 10 months ago by PhilEHolmes
Modified:
11 years, 10 months ago
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

New patchset creating make log-clean. Patchset 1 fixed issue 2415 by deleting all the logfiles created during make, make doc or make test. The deletion is non-selective - running make clean, make doc clean or make test clean will delete all the logfiles created in the build tree. However, that's lots simpler than trying to do be more selective and shouldn't cause a problem in the real world - the logfiles are really only of any use after a failed build.

Patch Set 1 #

Total comments: 3

Patch Set 2 : Patchset 2 - different approach #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -7 lines) Patch
M Documentation/included/compile.itexi View 1 2 chunks +19 lines, -6 lines 0 comments Download
M stepmake/stepmake/generic-targets.make View 1 2 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 6
PhilEHolmes
Please review.
11 years, 10 months ago (2012-06-11 13:07:23 UTC) #1
Graham Percival
LGTM
11 years, 10 months ago (2012-06-12 04:33:27 UTC) #2
John Mandereau
I'm not certain cleaning the build tree should include log files cleaning, when a simple ...
11 years, 10 months ago (2012-06-12 12:30:59 UTC) #3
PhilEHolmes
Please review
11 years, 10 months ago (2012-06-13 15:29:57 UTC) #4
John Mandereau
LGTM
11 years, 10 months ago (2012-06-14 11:23:52 UTC) #5
Graham Percival
11 years, 10 months ago (2012-06-16 07:19:17 UTC) #6
LGTM, and if you want to push it right now instead of waiting for the countdown
to officially end I think that's entirely fine.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b