releaseTextures portion of GrDrawState Ref textures CL

This CL breaks out the releaseTextures portion of http://codereview.appspot.com/6251049/ and modifies it to have an AutoTextureRelease helper class

[bsalomon, 2012-06-13 15:37:33]

http://codereview.appspot.com/6299081/diff/1/src/gpu/GrContext.cpp
File src/gpu/GrContext.cpp (right):

http://codereview.appspot.com/6299081/diff/1/src/gpu/GrContext.cpp#newcode252
src/gpu/GrContext.cpp:252: drawState->setTexture(0, NULL);
Can the caller of this function declare an AutoTextureRelease before the loop
that calls this (and same for morphology)?

http://codereview.appspot.com/6299081/diff/1/src/gpu/GrContext.cpp#newcode1399
src/gpu/GrContext.cpp:1399: drawState->setTexture(0, NULL);
Doesn't the AutoStateRestore above already release the texture?

http://codereview.appspot.com/6299081/diff/1/src/gpu/GrContext.cpp#newcode1441
src/gpu/GrContext.cpp:1441: drawState->setTexture(0, NULL);
ASR does this for us?

http://codereview.appspot.com/6299081/diff/1/src/gpu/GrContext.cpp#newcode1545
src/gpu/GrContext.cpp:1545: drawState->setTexture(0, NULL);
ASR does this for us? Also the fact that we added the call twice in this
function seems like an argument for instead using the stack helper up top.

[TomH, 2012-06-13 15:55:32]

This + Brian's description on 6251049 sounds good to me.

[robertphillips, 2012-06-13 17:37:33]

http://codereview.appspot.com/6299081/diff/1/src/gpu/GrContext.cpp
File src/gpu/GrContext.cpp (right):

http://codereview.appspot.com/6299081/diff/1/src/gpu/GrContext.cpp#newcode252
src/gpu/GrContext.cpp:252: drawState->setTexture(0, NULL);
Deleted b.c. of AutoStateRestore

http://codereview.appspot.com/6299081/diff/1/src/gpu/GrContext.cpp#newcode400
src/gpu/GrContext.cpp:400: texture->releaseRenderTarget();
Removed b.c. of AutoStateRestore

http://codereview.appspot.com/6299081/diff/1/src/gpu/GrContext.cpp#newcode1399
src/gpu/GrContext.cpp:1399: drawState->setTexture(0, NULL);
On 2012/06/13 15:37:33, bsalomon wrote:
> Doesn't the AutoStateRestore above already release the texture?

Done.

http://codereview.appspot.com/6299081/diff/1/src/gpu/GrContext.cpp#newcode1441
src/gpu/GrContext.cpp:1441: drawState->setTexture(0, NULL);
On 2012/06/13 15:37:33, bsalomon wrote:
> ASR does this for us?

Done.

http://codereview.appspot.com/6299081/diff/1/src/gpu/GrContext.cpp#newcode1545
src/gpu/GrContext.cpp:1545: drawState->setTexture(0, NULL);
On 2012/06/13 15:37:33, bsalomon wrote:
> ASR does this for us? Also the fact that we added the call twice in this
> function seems like an argument for instead using the stack helper up top.

Done.

[TomH, 2012-06-13 17:38:20]

LGTM.

[bsalomon, 2012-06-13 18:02:58]

On 2012/06/13 17:38:20, TomH wrote:
> LGTM.

LGTM

[robertphillips, 2012-06-13 18:50:08]

committed as r4254