Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(308)

Issue 6298085: code review 6298085: exp/html/atom: add some more atoms. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 12 months ago by nigeltao
Modified:
13 years, 12 months ago
Reviewers:
rsc
CC:
r, dsymonds, golang-dev
Visibility:
Public.

Description

exp/html/atom: add some more atoms.

Patch Set 1 #

Patch Set 2 : diff -r d13076ae2f82 https://code.google.com/p/go/ #

Patch Set 3 : diff -r d13076ae2f82 https://code.google.com/p/go/ #

Patch Set 4 : diff -r d13076ae2f82 https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+556 lines, -536 lines) Patch
M src/pkg/exp/html/atom/gen.go View 1 2 chunks +5 lines, -0 lines 0 comments Download
M src/pkg/exp/html/atom/table.go View 1 2 chunks +546 lines, -536 lines 0 comments Download
M src/pkg/exp/html/atom/table_test.go View 1 4 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 5
nigeltao
Hello r@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/
13 years, 12 months ago (2012-06-15 04:05:27 UTC) #1
dsymonds
On Fri, Jun 15, 2012 at 2:05 PM, <nigeltao@golang.org> wrote: > Description: > exp/html/atom: add ...
13 years, 12 months ago (2012-06-15 04:07:47 UTC) #2
r
LGTM the unbearable lightness of HTML5
13 years, 12 months ago (2012-06-15 04:22:31 UTC) #3
nigeltao
*** Submitted as http://code.google.com/p/go/source/detail?r=c868b808b7a7 *** exp/html/atom: add some more atoms. R=r, dsymonds CC=golang-dev http://codereview.appspot.com/6298085
13 years, 12 months ago (2012-06-15 05:39:43 UTC) #4
rsc
13 years, 12 months ago (2012-06-15 16:41:59 UTC) #5
On Fri, Jun 15, 2012 at 12:07 AM, David Symonds <dsymonds@golang.org> wrote:
> Careful you don't trigger fission on that package.

I actually worry about this. Eventually the hash table is going to
need 1024 entries instead of 512.

Russ
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b