cmd/jujud: Provisioner should Open it's own state connection

cmd/jujud: Provisioner should Open it's own state connection

This small branch is extracted from my working copy. By passing the PA
a state.Info, rather than a connected (and possibly shared) state.Conn
it ensures they aren't sharing a single state connection.

https://code.launchpad.net/~dave-cheney/juju-core/go-cmd-jujud-provisioner-state-and-close/+merge/109304

(do not edit description out of merge proposal)

[dave_cheney.net, 2012-06-08 07:43:54]

Please take a look.

[fwereade, 2012-06-08 15:05:32]

What's the benefit of testing with 2 separate connections?

[dave_cheney.net, 2012-06-10 23:18:06]

On 2012/06/08 15:05:32, fwereade wrote:
> What's the benefit of testing with 2 separate connections?

There is no benefit, in fact it was very confusing. Now the test harness has a
connection to the state, to simulate an external client, and the PA has it's own
connection to observe those changes. Previously there were problems with who
owned this shared connection, who should close it, etc.

[rog, 2012-06-11 08:13:06]

On 2012/06/08 07:43:54, dfc wrote:
> Please take a look.

LGTM

[niemeyer, 2012-06-11 18:54:57]

LGTM

[dave_cheney.net, 2012-06-11 22:10:34]

*** Submitted:

cmd/jujud: Provisioner should Open it's own state connection

This small branch is extracted from my working copy. By passing the PA
a state.Info, rather than a connected (and possibly shared) state.Conn
it ensures they aren't sharing a single state connection.

R=fwereade, rog, niemeyer
CC=
https://codereview.appspot.com/6298061