Issue 6297089: Make locked_file.py understand win32file primitives for better awesomeness.

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 1 month ago by cache

Modified:
13 years, 1 month ago

Reviewers:
jcgregorio_google

CC:
google-api-python-client_googlegroups.com

Visibility:
Public.

Patch Set 3 : Fix broken comment referring to lockf. #

Total comments: 4

Patch Set 4 : Address comments #

Created: 13 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+98 lines, -9 lines)			Patch
	M	oauth2client/locked_file.py	View	1 2 3	3 chunks	+98 lines, -9 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

jcgregorio_google

http://codereview.appspot.com/6297089/diff/2001/oauth2client/locked_file.py File oauth2client/locked_file.py (right): http://codereview.appspot.com/6297089/diff/2001/oauth2client/locked_file.py#newcode253 oauth2client/locked_file.py:253: win32con.LOCKFILE_FAIL_IMMEDIATELY|win32con.LOCKFILE_EXCLUSIVE_LOCK, 80 chars http://codereview.appspot.com/6297089/diff/1003/oauth2client/locked_file.py File oauth2client/locked_file.py (right): http://codereview.appspot.com/6297089/diff/1003/oauth2client/locked_file.py#newcode262 oauth2client/locked_file.py:262: ...

13 years, 1 month ago (2012-06-15 13:58:55 UTC) #1

jcgregorio_google

lgtm On 2012/06/15 13:58:55, jcgregorio_google wrote: > http://codereview.appspot.com/6297089/diff/2001/oauth2client/locked_file.py > File oauth2client/locked_file.py (right): > > http://codereview.appspot.com/6297089/diff/2001/oauth2client/locked_file.py#newcode253 ...

13 years, 1 month ago (2012-06-20 13:48:41 UTC) #2

jcgregorio_google

13 years, 1 month ago (2012-06-20 13:50:31 UTC) #3

Committed at
http://code.google.com/p/google-api-python-client/source/detail?r=47373e0aee0...

On 2012/06/20 13:48:41, jcgregorio_google wrote:
> lgtm
> 
> On 2012/06/15 13:58:55, jcgregorio_google wrote:
> > http://codereview.appspot.com/6297089/diff/2001/oauth2client/locked_file.py
> > File oauth2client/locked_file.py (right):
> > 
> >
>
http://codereview.appspot.com/6297089/diff/2001/oauth2client/locked_file.py#n...
> > oauth2client/locked_file.py:253:
> > win32con.LOCKFILE_FAIL_IMMEDIATELY|win32con.LOCKFILE_EXCLUSIVE_LOCK,
> > 80 chars
> > 
> > http://codereview.appspot.com/6297089/diff/1003/oauth2client/locked_file.py
> > File oauth2client/locked_file.py (right):
> > 
> >
>
http://codereview.appspot.com/6297089/diff/1003/oauth2client/locked_file.py#n...
> > oauth2client/locked_file.py:262: if e[0] != Win32Opener.FILE_IN_USE_ERROR:
> > _Win32Opener
> > 
> >
>
http://codereview.appspot.com/6297089/diff/1003/oauth2client/locked_file.py#n...
> > oauth2client/locked_file.py:282: if e[0] ==
> > Win32Opener.FILE_ALREADY_UNLOCKED_ERROR:
> > _Win32Opener
> > 
> >
>
http://codereview.appspot.com/6297089/diff/1003/oauth2client/locked_file.py#n...
> > oauth2client/locked_file.py:283: pass
> > How about:
> > 
> > if e[0] != Win32Opener.FILE_ALREADY_UNLOCKED_ERROR:
> >   raise
> > 
> >
>
http://codereview.appspot.com/6297089/diff/1003/oauth2client/locked_file.py#n...
> > oauth2client/locked_file.py:303: use_fcntl: bool, Whether or not fcntl-based
> > locking should be used.
> > Why have two flags? Why not a single flag use_native_locking that uses fcntl
> on
> > posix systems and win32 locking on windows?

Expand All Messages | Collapse All Messages