Issue 6297051: Issue 2590: GUB release instructions fail for upload

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6297051: Issue 2590: GUB release instructions fail for upload (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 11 months ago by dak

Modified:
12 years, 11 months ago

Reviewers:
Graham Percival

CC:
lilypond-devel_gnu.org

Base URL:
http://git.savannah.gnu.org/gitweb/?p=lilypond.git/trunk/

Visibility:
Public.

Description

Issue 2590: GUB release instructions fail for upload Uploaded for review because it has become slightly larger than suggested.

Patch Set 1 #

Total comments: 1

Created: 12 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -1 line)			Patch
	M	Documentation/contributor/release-work.itexi	View		2 chunks	+17 lines, -1 line	1 comment	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages

Graham Percival

12 years, 11 months ago (2012-06-06 18:47:08 UTC) #1

LGTM, one little nitpick but I don't mind if you want to keep it as-is.

http://codereview.appspot.com/6297051/diff/1/Documentation/contributor/releas...
File Documentation/contributor/release-work.itexi (right):

http://codereview.appspot.com/6297051/diff/1/Documentation/contributor/releas...
Documentation/contributor/release-work.itexi:190: git fetch
I'd rather have this merged in the next @example, since that means one less
copy&paste, and in any case aren't the fetch / checkout "spiritually" combined
to form "get the latest staging" ?

Expand All Messages | Collapse All Messages