Issue 6296074: refactor on apps/frontend/views.py and items/__init__.py

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6296074: refactor on apps/frontend/views.py and items/init.py (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 9 months ago by xiaq

Modified:
12 years, 9 months ago

Reviewers:
thomas.j.waldmann, Reimar Bauer, waldi

Visibility:
Public.

More Reviews

Patch Set 2 : fix broken +meta view #

Total comments: 2

Patch Set 3 : fix failing pep8 tests #

Patch Set 4 : remove outdated comment #

Patch Set 5 : renamed ModifyForm.populate to _load; fix broken anywikidraw (+ operator on dict is not supported..… #

Created: 12 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+144 lines, -207 lines)			Patch
	M	MoinMoin/apps/frontend/views.py	View	1	6 chunks	+45 lines, -42 lines	0 comments	Download
	M	MoinMoin/items/__init__.py	View	1 2 3 4	11 chunks	+99 lines, -165 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

waldi

http://codereview.appspot.com/6296074/diff/2001/MoinMoin/apps/frontend/views.py File MoinMoin/apps/frontend/views.py (right): http://codereview.appspot.com/6296074/diff/2001/MoinMoin/apps/frontend/views.py#newcode278 MoinMoin/apps/frontend/views.py:278: :param add_trail: whether to call flaskg.user.add_trail This is only ...

12 years, 9 months ago (2012-06-14 14:26:34 UTC) #1

xiaq

12 years, 9 months ago (2012-06-14 14:28:32 UTC) #2

http://codereview.appspot.com/6296074/diff/2001/MoinMoin/apps/frontend/views.py
File MoinMoin/apps/frontend/views.py (right):

http://codereview.appspot.com/6296074/diff/2001/MoinMoin/apps/frontend/views....
MoinMoin/apps/frontend/views.py:278: :param add_trail: whether to call
flaskg.user.add_trail
On 2012/06/14 14:26:34, waldi wrote:
> This is only used once.

yes, and same for abort404 too. but i didn't work out a better way. what do you
suggest?

Expand All Messages | Collapse All Messages