Instance Counting v2

First version didn't scale well mainly b.c. it required all the header files to be present in gmmain.cpp to be able to print out. This version attempts to fix that problem.

[bsalomon, 2012-06-13 14:13:52]

On 2012/06/13 14:09:52, robertphillips wrote:

Would it be possible to rely on the class having an INHERITED typedef rather
than requiring a base class name?

[robertphillips, 2012-06-13 17:56:14]

Done. There was/is a bit of unpleasantness in SkInstCnt to handle the root case.

[bsalomon, 2012-06-13 18:20:50]

Really a style question for Mike: The header that declares the macro is in a
public include dir. Should we prefix the macros with SK_?

http://codereview.appspot.com/6296069/diff/6001/include/core/SkInstCnt.h
File include/core/SkInstCnt.h (right):

http://codereview.appspot.com/6296069/diff/6001/include/core/SkInstCnt.h#newc...
include/core/SkInstCnt.h:42: \
This may not matter for the objects types you're working with here is something
I encountered something with a TLS instance counter I am writing:

If the object being counted has a compiler-generated copy constructor it will
call the compiler-generated copy cons for SkInstanceCountHelper, which will do
nothing. In my case I had to add a copy cons that bumps the instance count.

[reed1, 2012-06-13 18:22:14]

lets prefix with SK_

[robertphillips, 2012-06-13 18:45:55]

Added SK_ prefix to macros & copy ctor

http://codereview.appspot.com/6296069/diff/6001/include/core/SkInstCnt.h
File include/core/SkInstCnt.h (right):

http://codereview.appspot.com/6296069/diff/6001/include/core/SkInstCnt.h#newc...
include/core/SkInstCnt.h:42: \
On 2012/06/13 18:20:50, bsalomon wrote:
> This may not matter for the objects types you're working with here is
something
> I encountered something with a TLS instance counter I am writing:
> 
> If the object being counted has a compiler-generated copy constructor it will
> call the compiler-generated copy cons for SkInstanceCountHelper, which will do
> nothing. In my case I had to add a copy cons that bumps the instance count.

Done.

[bsalomon, 2012-06-13 18:52:16]

LGTM

[robertphillips, 2012-06-13 18:54:32]

committed as r4255