Issue 6296046: Add GL function pointers for GL_NV_path_rendering

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6296046: Add GL function pointers for GL_NV_path_rendering (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 5 months ago by bsalomon

Modified:
12 years, 5 months ago

Reviewers:
TomH

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

Patch Set 1 #

Patch Set 2 : add comment #

Total comments: 3

Created: 12 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+409 lines, -2 lines)			Patch
M	include/gpu/gl/GrGLFunctions.h	View	1	1 chunk	+56 lines, -0 lines	0 comments	Download
M	include/gpu/gl/GrGLInterface.h	View	1	1 chunk	+56 lines, -0 lines	0 comments	Download
M	src/gpu/gl/GrGLDefines.h	View		2 chunks	+180 lines, -2 lines	2 comments	Download
M	src/gpu/gl/GrGLInterface.cpp	View		1 chunk	+62 lines, -0 lines	1 comment	Download
M	src/gpu/gl/win/GrGLCreateNativeInterface_win.cpp	View		2 chunks	+55 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

TomH

We don't have to initialize these to NULL on other platforms? Otherwise LGTM. http://codereview.appspot.com/6296046/diff/2001/src/gpu/gl/GrGLDefines.h File ...

12 years, 5 months ago (2012-06-06 15:12:33 UTC) #2

bsalomon

12 years, 5 months ago (2012-06-06 15:19:38 UTC) #3

Fixed nits, landed as 4192.

On 2012/06/06 15:12:33, TomH wrote:
> We don't have to initialize these to NULL on other platforms?

The function pointers are actually templated objects of this type:
    template <typename FNPTR_TYPE> class GLPtr {
    public:
        GLPtr() : fPtr(NULL) {}
        GLPtr operator =(FNPTR_TYPE ptr) { fPtr = ptr; return *this; }
        operator FNPTR_TYPE() const { return fPtr; }
    private:
        FNPTR_TYPE fPtr;
    };

And thus they self-initialize to NULL.


> 
> Otherwise LGTM.
> 
> http://codereview.appspot.com/6296046/diff/2001/src/gpu/gl/GrGLDefines.h
> File src/gpu/gl/GrGLDefines.h (right):
> 
>
http://codereview.appspot.com/6296046/diff/2001/src/gpu/gl/GrGLDefines.h#newc...
> src/gpu/gl/GrGLDefines.h:807: // path types?
> Unicode encodings
> 
>
http://codereview.appspot.com/6296046/diff/2001/src/gpu/gl/GrGLDefines.h#newc...
> src/gpu/gl/GrGLDefines.h:871: // path list mosdes (glGetPathSpacing)
> nit: mosdes = modes
> 
> http://codereview.appspot.com/6296046/diff/2001/src/gpu/gl/GrGLInterface.cpp
> File src/gpu/gl/GrGLInterface.cpp (right):
> 
>
http://codereview.appspot.com/6296046/diff/2001/src/gpu/gl/GrGLInterface.cpp#...
> src/gpu/gl/GrGLInterface.cpp:195: // The below two blocks are cehcks for
> functions used with
> nit: cehcks

Expand All Messages | Collapse All Messages