Issue 6295108: Parameter values of None should be treated as missing.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6295108: Parameter values of None should be treated as missing. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years ago by jcgregorio_google

Modified:
13 years ago

Reviewers:
rmistry

CC:
google-api-python-client_googlegroups.com

Visibility:
Public.

Patch Set 1 #

Total comments: 2

Created: 13 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -9 lines)			Patch
	M	apiclient/discovery.py	View		2 chunks	+7 lines, -2 lines	2 comments	Download
	M	tests/test_discovery.py	View		2 chunks	+13 lines, -7 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

rmistry

http://codereview.appspot.com/6295108/diff/1/apiclient/discovery.py File apiclient/discovery.py (right): http://codereview.appspot.com/6295108/diff/1/apiclient/discovery.py#newcode453 apiclient/discovery.py:453: del kwargs[name] Should we log a warning as well?

13 years ago (2012-06-20 16:11:42 UTC) #2

jcgregorio_google

13 years ago (2012-06-20 16:22:25 UTC) #4

Committed as
http://code.google.com/p/google-api-python-client/source/detail?r=97e37f2a20c...

http://codereview.appspot.com/6295108/diff/1/apiclient/discovery.py
File apiclient/discovery.py (right):

http://codereview.appspot.com/6295108/diff/1/apiclient/discovery.py#newcode453
apiclient/discovery.py:453: del kwargs[name]
On 2012/06/20 16:11:42, rmistry wrote:
> Should we log a warning as well?

I don't think so, the reason I had to change this was because there were
non-zero number of people that expected None to mean "don't use this parameter".

Expand All Messages | Collapse All Messages