Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1054)

Issue 6295095: fix multichar warnings (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years ago by guanqun
Modified:
13 years ago
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk
Visibility:
Public.

Description

fix multichar warnings BUG=http://code.google.com/p/skia/issues/detail?id=630 TEST=gcc and clang under Linux platform

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M gyp/common_conditions.gypi View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6
guanqun
As we know what we're doing, so don't check the multichar in compilers, it would ...
13 years ago (2012-06-18 08:16:04 UTC) #1
bsalomon
On 2012/06/18 08:16:04, guanqun wrote: > As we know what we're doing, so don't check ...
13 years ago (2012-06-18 12:54:46 UTC) #2
bungeman
On 2012/06/18 12:54:46, bsalomon wrote: > On 2012/06/18 08:16:04, guanqun wrote: > > As we ...
13 years ago (2012-06-18 13:57:04 UTC) #3
guanqun
On 2012/06/18 13:57:04, bungeman wrote: > I actually have a change set to get rid ...
13 years ago (2012-06-20 01:59:02 UTC) #4
bungeman
On 2012/06/20 01:59:02, guanqun wrote: > On 2012/06/18 13:57:04, bungeman wrote: > > I actually ...
13 years ago (2012-06-20 14:54:27 UTC) #5
guanqun
13 years ago (2012-06-21 01:39:43 UTC) #6
On 2012/06/20 14:54:27, bungeman wrote:
> See http://codereview.appspot.com/6305117/ .

Thanks, closing this issue.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b