As we know what we're doing, so don't check the multichar in compilers, it would
leave us with less noises... Please review. Jochen is the report of this issue,
added as well.
On 2012/06/18 08:16:04, guanqun wrote:
> As we know what we're doing, so don't check the multichar in compilers, it
would
> leave us with less noises... Please review. Jochen is the report of this
issue,
> added as well.
Assuming this is correct, we'd have to add the suppression to chrome's skia.gyp
as well, right?
On 2012/06/18 12:54:46, bsalomon wrote:
> On 2012/06/18 08:16:04, guanqun wrote:
> > As we know what we're doing, so don't check the multichar in compilers, it
> would
> > leave us with less noises... Please review. Jochen is the report of this
> issue,
> > added as well.
>
> Assuming this is correct, we'd have to add the suppression to chrome's
skia.gyp
> as well, right?
I actually have a change set to get rid of these, so we may not need to do this
at all. I'll update this with a link later today.
On 2012/06/18 13:57:04, bungeman wrote:
> I actually have a change set to get rid of these, so we may not need to do
this
> at all. I'll update this with a link later today.
Hi Ben, any updates? Should I close this issue and you'll take care of this
issue?
Thanks!
On 2012/06/20 01:59:02, guanqun wrote:
> On 2012/06/18 13:57:04, bungeman wrote:
> > I actually have a change set to get rid of these, so we may not need to do
> this
> > at all. I'll update this with a link later today.
>
> Hi Ben, any updates? Should I close this issue and you'll take care of this
> issue?
>
> Thanks!
See http://codereview.appspot.com/6305117/ .
Issue 6295095: fix multichar warnings
(Closed)
Created 13 years ago by guanqun
Modified 13 years ago
Reviewers: bsalomon, jochen1, epoger, bungeman
Base URL: http://skia.googlecode.com/svn/trunk
Comments: 0