media download

Adds support for media download, and resumable media download.

[jcgregorio_google, 2012-06-15 14:07:08]

On 2012/06/14 02:02:47, jcgregorio_google wrote:

Ping. Or I can submit TBR if you're busy.

[jcgregorio_google, 2012-06-18 14:21:40]

On 2012/06/15 14:07:08, jcgregorio_google wrote:
> On 2012/06/14 02:02:47, jcgregorio_google wrote:
> 
> Ping. Or I can submit TBR if you're busy.

Committed at
http://code.google.com/p/google-api-python-client/source/detail?r=7355aaea649...

[aiuto, 2012-06-18 15:22:42]

really busy. leaving for scotland tonight. Finishing a bunch of things.

On Mon, Jun 18, 2012 at 10:21 AM, <jcgregorio@google.com> wrote:

> On 2012/06/15 14:07:08, jcgregorio_google wrote:
>
>> On 2012/06/14 02:02:47, jcgregorio_google wrote:
>>
>
>  Ping. Or I can submit TBR if you're busy.
>>
>
> Committed at
> http://code.google.com/p/**google-api-python-client/**source/detail?r=**
>
7355aaea6494496b1ce3c4f7596f1e**0dfe73d72b<http://code.google.com/p/google-api-python-client/source/detail?r=7355aaea6494496b1ce3c4f7596f1e0dfe73d72b>
>
>
http://codereview.appspot.com/**6295077/<http://codereview.appspot.com/6295077/>
>

[aiuto, 2012-07-11 19:09:23]

sorry I lost this. I never think to look in rietveld

http://codereview.appspot.com/6295077/diff/2002/apiclient/discovery.py
File apiclient/discovery.py (right):

http://codereview.appspot.com/6295077/diff/2002/apiclient/discovery.py#newcod...
apiclient/discovery.py:500: # If there is no schema for the response then
presume a binary blob.
This comment is no longer completely true.

http://codereview.appspot.com/6295077/diff/2002/apiclient/http.py
File apiclient/http.py (right):

http://codereview.appspot.com/6295077/diff/2002/apiclient/http.py#newcode341
apiclient/http.py:341: self._fh = fh
you might want _fd to align with the other classes

http://codereview.appspot.com/6295077/diff/2002/apiclient/http.py#newcode530
apiclient/http.py:530: self.fh_ = fh
fh_ ? Did you go all C++'y this week?
Also, most of the other Upload code uses fd.

[jcgregorio_google, 2012-07-12 16:18:06]

Since this was submitted TBR, the edits below are in this new review:

  http://codereview.appspot.com/6374062/

http://codereview.appspot.com/6295077/diff/2002/apiclient/discovery.py
File apiclient/discovery.py (right):

http://codereview.appspot.com/6295077/diff/2002/apiclient/discovery.py#newcod...
apiclient/discovery.py:500: # If there is no schema for the response then
presume a binary blob.
On 2012/07/11 19:09:23, aiuto wrote:
> This comment is no longer completely true.

Done.

http://codereview.appspot.com/6295077/diff/2002/apiclient/http.py
File apiclient/http.py (right):

http://codereview.appspot.com/6295077/diff/2002/apiclient/http.py#newcode341
apiclient/http.py:341: self._fh = fh
On 2012/07/11 19:09:23, aiuto wrote:
> you might want _fd to align with the other classes

Done.

http://codereview.appspot.com/6295077/diff/2002/apiclient/http.py#newcode530
apiclient/http.py:530: self.fh_ = fh
On 2012/07/11 19:09:23, aiuto wrote:
> fh_ ? Did you go all C++'y this week?
> Also, most of the other Upload code uses fd.

Done.