Issue 6295046: Move stencil param adjustment to GrClipMaskManager, attempt to make GrGpuGL::flushStencil readable

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6295046: Move stencil param adjustment to GrClipMaskManager, attempt to make GrGpuGL::flushStencil readable (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 1 month ago by bsalomon

Modified:
12 years, 1 month ago

Reviewers:
robertphillips

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

Patch Set 2 : revert unintended changes #

Patch Set 4 : sklafj #

Total comments: 1

Created: 12 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+270 lines, -238 lines)			Patch
M	src/gpu/GrClipMaskManager.h	View		2 chunks	+35 lines, -6 lines	0 comments	Download
M	src/gpu/GrClipMaskManager.cpp	View	1 2 3	2 chunks	+94 lines, -1 line	0 comments	Download
M	src/gpu/GrGpu.cpp	View		1 chunk	+0 lines, -81 lines	0 comments	Download
M	src/gpu/gl/GrGpuGL.h	View		1 chunk	+2 lines, -16 lines	0 comments	Download
M	src/gpu/gl/GrGpuGL.cpp	View		5 chunks	+139 lines, -134 lines	1 comment	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

bsalomon

http://codereview.appspot.com/6295046/diff/7001/src/gpu/gl/GrGpuGL.cpp File src/gpu/gl/GrGpuGL.cpp (right): http://codereview.appspot.com/6295046/diff/7001/src/gpu/gl/GrGpuGL.cpp#newcode501 src/gpu/gl/GrGpuGL.cpp:501: // stencil on the next draw. Since the enum ...

12 years, 1 month ago (2012-06-05 19:25:05 UTC) #1

Closed with r4173

Expand All Messages | Collapse All Messages