Issue 6295044: Move stuff from protected to private in GrGpuGL

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6295044: Move stuff from protected to private in GrGpuGL (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 1 month ago by bsalomon

Modified:
12 years, 1 month ago

Reviewers:
TomH

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

Patch Set 2 : rename var #

Total comments: 2

Created: 12 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+49 lines, -44 lines)			Patch
M	src/gpu/gl/GrGpuGL.h	View	1	5 chunks	+37 lines, -32 lines	2 comments	Download
M	src/gpu/gl/GrGpuGL.cpp	View	1	2 chunks	+5 lines, -5 lines	0 comments	Download
M	src/gpu/gl/GrGpuGL_program.cpp	View		3 chunks	+7 lines, -7 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

bsalomon

There were a bunch of members and functions in GrGpuGL that were protected so that ...

12 years, 1 month ago (2012-06-05 12:49:31 UTC) #1

TomH

LGTM http://codereview.appspot.com/6295044/diff/2001/src/gpu/gl/GrGpuGL.h File src/gpu/gl/GrGpuGL.h (right): http://codereview.appspot.com/6295044/diff/2001/src/gpu/gl/GrGpuGL.h#newcode373 src/gpu/gl/GrGpuGL.h:373: /// @} I don't see a matching //@{? ...

12 years, 1 month ago (2012-06-05 13:07:16 UTC) #2

bsalomon

http://codereview.appspot.com/6295044/diff/2001/src/gpu/gl/GrGpuGL.h File src/gpu/gl/GrGpuGL.h (right): http://codereview.appspot.com/6295044/diff/2001/src/gpu/gl/GrGpuGL.h#newcode373 src/gpu/gl/GrGpuGL.h:373: /// @} On 2012/06/05 13:07:16, TomH wrote: > I ...

12 years, 1 month ago (2012-06-05 13:42:58 UTC) #3

Closed with r4161

Expand All Messages | Collapse All Messages