We're keying off the paint's bitmap filter flag for all shaders. Really gradient shaders should ...
12 years, 6 months ago
(2012-06-04 20:17:46 UTC)
#1
We're keying off the paint's bitmap filter flag for all shaders. Really gradient
shaders should always be filtered and bitmap shaders should respect the skpaint
flag. Soon enough the custom effect will determine its own filter state, but
this fixes gradients for now.
BTW, since Chrome leaves isFilterBitmap() false for all SkShader drawing, it was not interpolating any ...
12 years, 6 months ago
(2012-06-04 20:29:24 UTC)
#4
BTW, since Chrome leaves isFilterBitmap() false for all SkShader drawing, it was
not interpolating any LUT lookups. So this change will require a few DRT
rebaselines when it rolls into Chrome (about 5 IIRC).
On 2012/06/04 20:29:24, Stephen White wrote: > BTW, since Chrome leaves isFilterBitmap() false for all ...
12 years, 6 months ago
(2012-06-04 21:19:56 UTC)
#5
On 2012/06/04 20:29:24, Stephen White wrote:
> BTW, since Chrome leaves isFilterBitmap() false for all SkShader drawing, it
was
> not interpolating any LUT lookups. So this change will require a few DRT
> rebaselines when it rolls into Chrome (about 5 IIRC).
Thanks, good to know! I'll run DRT in the morning before we prep a skia roll.
Issue 6286048: Always filter gradient textures
(Closed)
Created 12 years, 6 months ago by bsalomon
Modified 12 years, 6 months ago
Reviewers: Stephen White, TomH
Base URL: http://skia.googlecode.com/svn/trunk/
Comments: 0