Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1729)

Issue 6286048: Always filter gradient textures (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 3 months ago by bsalomon
Modified:
12 years, 3 months ago
Reviewers:
Stephen White, TomH
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Patch Set 1 #

Patch Set 2 : style, indent cases #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -19 lines) Patch
M src/gpu/SkGpuDevice.cpp View 1 1 chunk +22 lines, -19 lines 0 comments Download

Messages

Total messages: 6
bsalomon
We're keying off the paint's bitmap filter flag for all shaders. Really gradient shaders should ...
12 years, 3 months ago (2012-06-04 20:17:46 UTC) #1
Stephen White
LGTM
12 years, 3 months ago (2012-06-04 20:18:56 UTC) #2
TomH
LGTM
12 years, 3 months ago (2012-06-04 20:19:11 UTC) #3
Stephen White
BTW, since Chrome leaves isFilterBitmap() false for all SkShader drawing, it was not interpolating any ...
12 years, 3 months ago (2012-06-04 20:29:24 UTC) #4
bsalomon
On 2012/06/04 20:29:24, Stephen White wrote: > BTW, since Chrome leaves isFilterBitmap() false for all ...
12 years, 3 months ago (2012-06-04 21:19:56 UTC) #5
bsalomon
12 years, 3 months ago (2012-06-05 15:53:53 UTC) #6
Closed with r4151
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b