Issue 6282044: Corrects typesetting for tuplet bracket with inside-slur scripts

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6282044: Corrects typesetting for tuplet bracket with inside-slur scripts (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 10 months ago by MikeSol

Modified:
11 years, 10 months ago

Reviewers:
Keith

CC:
lilypond-devel_gnu.org

Visibility:
Public.

Description

Corrects typesetting for tuplet bracket with inside-slur scripts

Patch Set 1 #

Created: 11 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -10 lines)			Patch
	M	lily/slur.cc	View		2 chunks	+8 lines, -6 lines	0 comments	Download
	M	lily/tuplet-bracket.cc	View		1 chunk	+1 line, -4 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

Keith

Works good for me, and seems to make sense. Of course, this means the original ...

11 years, 10 months ago (2012-06-04 06:36:27 UTC) #1

MikeSol

11 years, 10 months ago (2012-06-04 06:45:40 UTC) #2

On 2012/06/04 06:36:27, Keith wrote:
> Works good for me, and seems to make sense.
> 
> Of course, this means the original tuplet/script collision never was fixed for
> for scripts under slurs, and now we do not even try.

Exactly - it's a large chunk to chew.  The tuplet bracket position depends on
scripts, which depend on slurs, which depend on tuplet brackets.  I'm sure there
are rules we could put in place to break the cycle, but it'd require rethinking
Y-offset callbacks for some of these grobs.

~Mike

Expand All Messages | Collapse All Messages