Fixed flattening of SkStippleMaskFilter

Added SkStippleMaskFilter to effects directory
Made use of flattening registration macros

[reed1, 2012-06-04 20:27:44]

http://codereview.appspot.com/6279052/diff/1/include/effects/SkStippleMaskFil...
File include/effects/SkStippleMaskFilter.h (right):

http://codereview.appspot.com/6279052/diff/1/include/effects/SkStippleMaskFil...
include/effects/SkStippleMaskFilter.h:17: public:
Is this needed? Same question for destructor?

http://codereview.appspot.com/6279052/diff/1/include/effects/SkStippleMaskFil...
include/effects/SkStippleMaskFilter.h:34: protected:
Is this needed?

http://codereview.appspot.com/6279052/diff/1/include/effects/SkStippleMaskFil...
include/effects/SkStippleMaskFilter.h:38: 
Is this needed?

http://codereview.appspot.com/6279052/diff/1/src/effects/SkStippleMaskFilter.cpp
File src/effects/SkStippleMaskFilter.cpp (right):

http://codereview.appspot.com/6279052/diff/1/src/effects/SkStippleMaskFilter....
src/effects/SkStippleMaskFilter.cpp:37: for (int x = 0; x < src.fBounds.width();
++x) {
Is this assert testing something from the input?

http://codereview.appspot.com/6279052/diff/1/src/effects/SkStippleMaskFilter....
src/effects/SkStippleMaskFilter.cpp:38: SkASSERT(size_t(scanline - dst->fImage)
< dstSize);
same as

scanline[x] = ((x+y) & 1) & 0xFF;

?

[reed1, 2012-06-04 20:28:35]

On 2012/06/04 20:27:44, reed1 wrote:
>
http://codereview.appspot.com/6279052/diff/1/include/effects/SkStippleMaskFil...
> File include/effects/SkStippleMaskFilter.h (right):
> 
>
http://codereview.appspot.com/6279052/diff/1/include/effects/SkStippleMaskFil...
> include/effects/SkStippleMaskFilter.h:17: public:
> Is this needed? Same question for destructor?
> 
>
http://codereview.appspot.com/6279052/diff/1/include/effects/SkStippleMaskFil...
> include/effects/SkStippleMaskFilter.h:34: protected:
> Is this needed?
> 
>
http://codereview.appspot.com/6279052/diff/1/include/effects/SkStippleMaskFil...
> include/effects/SkStippleMaskFilter.h:38: 
> Is this needed?
> 
>
http://codereview.appspot.com/6279052/diff/1/src/effects/SkStippleMaskFilter.cpp
> File src/effects/SkStippleMaskFilter.cpp (right):
> 
>
http://codereview.appspot.com/6279052/diff/1/src/effects/SkStippleMaskFilter....
> src/effects/SkStippleMaskFilter.cpp:37: for (int x = 0; x <
src.fBounds.width();
> ++x) {
> Is this assert testing something from the input?
> 
>
http://codereview.appspot.com/6279052/diff/1/src/effects/SkStippleMaskFilter....
> src/effects/SkStippleMaskFilter.cpp:38: SkASSERT(size_t(scanline -
dst->fImage)
> < dstSize);
> same as
> 
> scanline[x] = ((x+y) & 1) & 0xFF;
> 
> ?

Ignore this "same as" question

[robertphillips, 2012-06-04 20:56:31]

http://codereview.appspot.com/6279052/diff/1/include/effects/SkStippleMaskFil...
File include/effects/SkStippleMaskFilter.h (right):

http://codereview.appspot.com/6279052/diff/1/include/effects/SkStippleMaskFil...
include/effects/SkStippleMaskFilter.h:17: public:
Because we need the "buffer"-style ctor, C++ gets confused w/o this one (default
ctor becomes undefined).

http://codereview.appspot.com/6279052/diff/1/include/effects/SkStippleMaskFil...
include/effects/SkStippleMaskFilter.h:34: protected:
The SK_DECLARE_PUBLIC_FLATTENABLE_DESERIALIZATION_PROCS macro won't work w/o
this ctor

http://codereview.appspot.com/6279052/diff/1/include/effects/SkStippleMaskFil...
include/effects/SkStippleMaskFilter.h:38: 
On 2012/06/04 20:27:44, reed1 wrote:
> Is this needed?

Done.

http://codereview.appspot.com/6279052/diff/1/src/effects/SkStippleMaskFilter.cpp
File src/effects/SkStippleMaskFilter.cpp (right):

http://codereview.appspot.com/6279052/diff/1/src/effects/SkStippleMaskFilter....
src/effects/SkStippleMaskFilter.cpp:37: for (int x = 0; x < src.fBounds.width();
++x) {
On 2012/06/04 20:27:44, reed1 wrote:
> Is this assert testing something from the input?

Done.

[reed1, 2012-06-04 21:19:32]

lgtm w/ comment about funny

http://codereview.appspot.com/6279052/diff/7001/include/effects/SkStippleMask...
File include/effects/SkStippleMaskFilter.h (right):

http://codereview.appspot.com/6279052/diff/7001/include/effects/SkStippleMask...
include/effects/SkStippleMaskFilter.h:17: public:
Its funny (to me) to say INHERITED(). Is that needed? I don't think we do that
in other places in skia.

[robertphillips, 2012-06-04 21:25:06]

http://codereview.appspot.com/6279052/diff/7001/include/effects/SkStippleMask...
File include/effects/SkStippleMaskFilter.h (right):

http://codereview.appspot.com/6279052/diff/7001/include/effects/SkStippleMask...
include/effects/SkStippleMaskFilter.h:17: public:
Not needed but it seems that we do this in a bunch of places with parameters
(i.e., calling the base-class' ctor first in an initialization list) and in a
few places w/o params (e.g., SkOrderedReadBuffer, SkOrderedWriteBuffer). It
seems a bit funny to me too.

[robertphillips, 2012-06-05 12:55:31]

committed as r4154