GrTexture can now create its own cache key

Next refactoring in path to GrAutoScratchTexture::release

[robertphillips, 2012-06-04 18:40:22]

http://codereview.appspot.com/6269047/diff/1/src/gpu/GrTexture.cpp
File src/gpu/GrTexture.cpp (right):

http://codereview.appspot.com/6269047/diff/1/src/gpu/GrTexture.cpp#newcode90
src/gpu/GrTexture.cpp:90: kFilter_TextureBit          = kNPOT_TextureBit << 1,
Brian - What do you think about removing the kFilter flag?

http://codereview.appspot.com/6269047/diff/1/src/gpu/GrTexture.cpp#newcode104
src/gpu/GrTexture.cpp:104: // Instead of a client-provided key of the texture
contents
Moved here from gen_scratch_tex_key_values

http://codereview.appspot.com/6269047/diff/1/src/gpu/SkGr.cpp
File src/gpu/SkGr.cpp (right):

http://codereview.appspot.com/6269047/diff/1/src/gpu/SkGr.cpp#newcode198
src/gpu/SkGr.cpp:198: bool isOpaque) {
Brian - what do you think about removing isOpaque?

[bsalomon, 2012-06-04 18:53:18]

http://codereview.appspot.com/6269047/diff/1/src/gpu/SkGr.cpp
File src/gpu/SkGr.cpp (right):

http://codereview.appspot.com/6269047/diff/1/src/gpu/SkGr.cpp#newcode198
src/gpu/SkGr.cpp:198: bool isOpaque) {
On 2012/06/04 18:40:22, robertphillips wrote:
> Brian - what do you think about removing isOpaque?

I think that is OK.

[robertphillips, 2012-06-04 19:19:47]

Improved documentation of TextureBits in GrTexture.cpp

Replaced logic in GrContext::createAndLockTexture with use of
GrTexture::NeedsFiltering

Removed unused isOpaque flag from SkGr::BitmapConfig2PixelConfig

Removed SkGr::Bitmap2PixelConfig entry point

[bsalomon, 2012-06-04 19:48:51]

LGTM

http://codereview.appspot.com/6269047/diff/6001/include/gpu/GrTexture.h
File include/gpu/GrTexture.h (right):

http://codereview.appspot.com/6269047/diff/6001/include/gpu/GrTexture.h#newco...
include/gpu/GrTexture.h:28: typedef uint64_t TextureKey;
I take it the next evolution will remove this, right? 

(GrContext's client provides a GrTextureDesc that has the client-key [or zero
for scratch] to functions that today take a TextureKey).

[robertphillips, 2012-06-04 20:06:03]

committed as r4148

http://codereview.appspot.com/6269047/diff/6001/include/gpu/GrTexture.h
File include/gpu/GrTexture.h (right):

http://codereview.appspot.com/6269047/diff/6001/include/gpu/GrTexture.h#newco...
include/gpu/GrTexture.h:28: typedef uint64_t TextureKey;
Yes - that is all correct.