Issue 6269045: Linux compiler complaints

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6269045: Linux compiler complaints (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years ago by robertphillips

Modified:
12 years ago

Reviewers:
TomH

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Mainly the matrix inversion complaints but also some tab issues and coding standard stuff

Patch Set 2 : Addressed code review issues #

Created: 12 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+96 lines, -60 lines)			Patch
M	include/gpu/GrTypes.h	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	include/views/SkView.h	View	1	1 chunk	+9 lines, -3 lines	0 comments	Download
M	samplecode/SampleApp.cpp	View		1 chunk	+3 lines, -1 line	0 comments	Download
M	samplecode/SampleUnitMapper.cpp	View		2 chunks	+15 lines, -6 lines	0 comments	Download
M	src/views/SkView.cpp	View		2 chunks	+66 lines, -47 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

TomH

Good thing you aren't a manager, because you don't tolerate *any* complaints. :) LGTM modulo ...

12 years ago (2012-06-04 13:00:13 UTC) #2

robertphillips

http://codereview.appspot.com/6269045/diff/1/include/views/SkView.h File include/views/SkView.h (right): http://codereview.appspot.com/6269045/diff/1/include/views/SkView.h#newcode207 include/views/SkView.h:207: bool globalToLocal(SkPoint* pt) const { On 2012/06/04 13:00:13, TomH ...

12 years ago (2012-06-04 13:11:26 UTC) #3

committed as r4135

Expand All Messages | Collapse All Messages