Issue 6267046: remove 4x4 downsample filter mode

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6267046: remove 4x4 downsample filter mode (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 5 months ago by bsalomon

Modified:
12 years, 5 months ago

Reviewers:
TomH

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Patch Set 1 #

Total comments: 3

Created: 12 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+25 lines, -150 lines)			Patch
M	include/gpu/GrSamplerState.h	View	1 chunk	+0 lines, -9 lines	0 comments	Download
M	src/gpu/gl/GrGLProgram.h	View	4 chunks	+1 line, -10 lines	1 comment	Download
M	src/gpu/gl/GrGLProgram.cpp	View	6 chunks	+24 lines, -88 lines	2 comments	Download
M	src/gpu/gl/GrGpuGL.h	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	src/gpu/gl/GrGpuGL.cpp	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/gpu/gl/GrGpuGL_program.cpp	View	4 chunks	+0 lines, -34 lines	0 comments	Download
M	src/gpu/gl/GrGpuGL_unittest.cpp	View	1 chunk	+0 lines, -5 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

bsalomon

We are no longer using the 16x downsample anywhere. If we want to use it ...

12 years, 5 months ago (2012-06-04 19:44:12 UTC) #1

TomH

LGTM http://codereview.appspot.com/6267046/diff/1/src/gpu/gl/GrGLProgram.cpp File src/gpu/gl/GrGLProgram.cpp (right): http://codereview.appspot.com/6267046/diff/1/src/gpu/gl/GrGLProgram.cpp#newcode1273 src/gpu/gl/GrGLProgram.cpp:1273: } else if (NULL == customStage) { Smells ...

12 years, 5 months ago (2012-06-04 19:59:52 UTC) #2

bsalomon

12 years, 5 months ago (2012-06-04 20:09:01 UTC) #3

Landed as r4149

http://codereview.appspot.com/6267046/diff/1/src/gpu/gl/GrGLProgram.cpp
File src/gpu/gl/GrGLProgram.cpp (right):

http://codereview.appspot.com/6267046/diff/1/src/gpu/gl/GrGLProgram.cpp#newco...
src/gpu/gl/GrGLProgram.cpp:1273: } else if (NULL == customStage) {
On 2012/06/04 19:59:52, TomH wrote:
> Smells like progress...
> (Eventually we'll have to invert this so the stages can set the sample mode,
but
> for now is good.)

Invert?! We'll just remove it since the effect will be responsible for setting
up a matrix and it's own texture coords. The effect will have to decide if it's
worth worrying about identity matrices or not (and modify its stage key
accordingly).

Expand All Messages | Collapse All Messages