Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(889)

Issue 6266044: move texture flush and param update to separate function (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 4 months ago by bsalomon
Modified:
12 years, 4 months ago
Reviewers:
TomH
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Patch Set 1 #

Total comments: 2

Patch Set 2 : svn stat #

Unified diffs Side-by-side diffs Delta from patch set Stats (+107 lines, -100 lines) Patch
M src/gpu/gl/GrGLProgram.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M src/gpu/gl/GrGLProgram.cpp View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/gpu/gl/GrGpuGL.h View 1 2 chunks +3 lines, -1 line 0 comments Download
M src/gpu/gl/GrGpuGL.cpp View 1 2 chunks +74 lines, -87 lines 0 comments Download
M src/gpu/gl/GrGpuGL_program.cpp View 1 5 chunks +26 lines, -12 lines 0 comments Download

Messages

Total messages: 7
bsalomon
The GL state flush was broken into GrGpuGL's portion and the subclass's portion. This is ...
12 years, 4 months ago (2012-06-01 20:03:30 UTC) #1
TomH
LGTM http://codereview.appspot.com/6266044/diff/1/src/gpu/gl/GrGpuGL_program.cpp File src/gpu/gl/GrGpuGL_program.cpp (right): http://codereview.appspot.com/6266044/diff/1/src/gpu/gl/GrGpuGL_program.cpp#newcode508 src/gpu/gl/GrGpuGL_program.cpp:508: this->flushRenderTarget(rect); How did we get by without this ...
12 years, 4 months ago (2012-06-01 21:00:25 UTC) #2
bsalomon
http://codereview.appspot.com/6266044/diff/1/src/gpu/gl/GrGpuGL_program.cpp File src/gpu/gl/GrGpuGL_program.cpp (right): http://codereview.appspot.com/6266044/diff/1/src/gpu/gl/GrGpuGL_program.cpp#newcode508 src/gpu/gl/GrGpuGL_program.cpp:508: this->flushRenderTarget(rect); On 2012/06/01 21:00:25, TomH wrote: > How did ...
12 years, 4 months ago (2012-06-01 21:04:28 UTC) #3
bsalomon
Closed, r4134.
12 years, 4 months ago (2012-06-04 13:17:22 UTC) #4
bsalomon
When this was landed the first time it broke stuff. The problem was that we ...
12 years, 4 months ago (2012-06-04 17:58:13 UTC) #5
TomH
ReLGTM
12 years, 4 months ago (2012-06-04 19:00:37 UTC) #6
bsalomon
12 years, 4 months ago (2012-06-04 19:28:08 UTC) #7
Relanded as r4142
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b