LGTM http://codereview.appspot.com/6266044/diff/1/src/gpu/gl/GrGpuGL_program.cpp File src/gpu/gl/GrGpuGL_program.cpp (right): http://codereview.appspot.com/6266044/diff/1/src/gpu/gl/GrGpuGL_program.cpp#newcode508 src/gpu/gl/GrGpuGL_program.cpp:508: this->flushRenderTarget(rect); How did we get by without this ...
12 years, 5 months ago
(2012-06-01 21:00:25 UTC)
#2
When this was landed the first time it broke stuff. The problem was that we ...
12 years, 5 months ago
(2012-06-04 17:58:13 UTC)
#5
When this was landed the first time it broke stuff. The problem was that we
relied on flushRenderTarget() to invalidate the programs' cached view matrices
when the view port changes. However, I had moved the call the
flushRenderTarget() below flushViewMatrix(). I decoupled these by having the
each program remember the last viewport size it saw.
Issue 6266044: move texture flush and param update to separate function
(Closed)
Created 12 years, 5 months ago by bsalomon
Modified 12 years, 5 months ago
Reviewers: TomH
Base URL: http://skia.googlecode.com/svn/trunk/
Comments: 2