Issue 6262049: Fix/hack operator = to not leak refcounted objects

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6262049: Fix/hack operator = to not leak refcounted objects (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 5 months ago by TomH

Modified:
12 years, 5 months ago

Reviewers:
bsalomon

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

Description

Agreed that this may be temporary. Some (many?) of these fields are going away in current or upcoming CLs. This doesn't seem to cause a bench regression on Linux NULLGPU.

Patch Set 1 #

Total comments: 2

Created: 12 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+23 lines, -1 line)			Patch
	M	include/gpu/GrSamplerState.h	View		1 chunk	+23 lines, -1 line	2 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

bsalomon

Mostly LGTM http://codereview.appspot.com/6262049/diff/1/include/gpu/GrSamplerState.h File include/gpu/GrSamplerState.h (right): http://codereview.appspot.com/6262049/diff/1/include/gpu/GrSamplerState.h#newcode144 include/gpu/GrSamplerState.h:144: //memcpy(this, &s, sizeof(GrSamplerState)); Let's just delete this ...

12 years, 5 months ago (2012-05-31 14:04:28 UTC) #2

Nits done, committed in r4092.

Expand All Messages | Collapse All Messages