Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2202)

Issue 6262049: Fix/hack operator = to not leak refcounted objects (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 1 month ago by TomH
Modified:
12 years, 1 month ago
Reviewers:
bsalomon
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Agreed that this may be temporary. Some (many?) of these fields are going away in current or upcoming CLs. This doesn't seem to cause a bench regression on Linux NULLGPU.

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -1 line) Patch
M include/gpu/GrSamplerState.h View 1 chunk +23 lines, -1 line 2 comments Download

Messages

Total messages: 3
TomH
As discussed.
12 years, 1 month ago (2012-05-31 13:51:01 UTC) #1
bsalomon
Mostly LGTM http://codereview.appspot.com/6262049/diff/1/include/gpu/GrSamplerState.h File include/gpu/GrSamplerState.h (right): http://codereview.appspot.com/6262049/diff/1/include/gpu/GrSamplerState.h#newcode144 include/gpu/GrSamplerState.h:144: //memcpy(this, &s, sizeof(GrSamplerState)); Let's just delete this ...
12 years, 1 month ago (2012-05-31 14:04:28 UTC) #2
TomH
12 years, 1 month ago (2012-05-31 14:23:58 UTC) #3
Nits done, committed in r4092.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b