On 2012/05/30 17:50:00, TomH wrote: LGTM, let's keep making more of this automatic for the ...
12 years, 5 months ago
(2012-05-30 18:10:25 UTC)
#2
On 2012/05/30 17:50:00, TomH wrote:
LGTM, let's keep making more of this automatic for the effects:
* Auto-append stage
* Auto-prepend Hungarian notation (if we decide to keep this)
* Let the caller give a single name for the varying, the builder generates the
fs and vs names automatically.
On 2012/05/30 18:10:25, bsalomon wrote: > On 2012/05/30 17:50:00, TomH wrote: > > LGTM, let's ...
12 years, 5 months ago
(2012-05-30 18:11:48 UTC)
#3
On 2012/05/30 18:10:25, bsalomon wrote:
> On 2012/05/30 17:50:00, TomH wrote:
>
> LGTM, let's keep making more of this automatic for the effects:
>
> * Auto-append stage
> * Auto-prepend Hungarian notation (if we decide to keep this)
> * Let the caller give a single name for the varying, the builder generates the
> fs and vs names automatically.
Maybe it should be called "emitGlobalVariables"?
Closed with r4083 (after a couple more tweaks discussed verbally). On 2012/05/30 18:11:48, bsalomon wrote: ...
12 years, 5 months ago
(2012-05-30 18:27:43 UTC)
#4
Closed with r4083 (after a couple more tweaks discussed verbally).
On 2012/05/30 18:11:48, bsalomon wrote:
> Maybe it should be called "emitGlobalVariables"?
Didn't do this yet because I'm not quite happy with 'emit' here; it seems
qualitatively different from the emitFS()/emitVS() functions which do literally
output code. Here we're setting up structs which glue will later read to drive
an emit.
Issue 6262046: Condense variable-creation functions in GrGLProgramStage, use new addUniform() API there
(Closed)
Created 12 years, 5 months ago by TomH
Modified 12 years, 5 months ago
Reviewers: bsalomon
Base URL: http://skia.googlecode.com/svn/trunk/
Comments: 0