Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(354)

Issue 6262046: Condense variable-creation functions in GrGLProgramStage, use new addUniform() API there (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 1 month ago by TomH
Modified:
12 years, 1 month ago
Reviewers:
bsalomon
CC:
robertphillips
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

At last, a net negative lines-of-code change!

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -63 lines) Patch
M src/gpu/effects/GrConvolutionEffect.cpp View 3 chunks +15 lines, -31 lines 0 comments Download
M src/gpu/gl/GrGLProgram.cpp View 2 chunks +3 lines, -7 lines 0 comments Download
M src/gpu/gl/GrGLProgramStage.h View 1 chunk +2 lines, -16 lines 0 comments Download
M src/gpu/gl/GrGLProgramStage.cpp View 1 chunk +1 line, -9 lines 0 comments Download

Messages

Total messages: 4
TomH
12 years, 1 month ago (2012-05-30 17:50:00 UTC) #1
bsalomon
On 2012/05/30 17:50:00, TomH wrote: LGTM, let's keep making more of this automatic for the ...
12 years, 1 month ago (2012-05-30 18:10:25 UTC) #2
bsalomon
On 2012/05/30 18:10:25, bsalomon wrote: > On 2012/05/30 17:50:00, TomH wrote: > > LGTM, let's ...
12 years, 1 month ago (2012-05-30 18:11:48 UTC) #3
TomH
12 years, 1 month ago (2012-05-30 18:27:43 UTC) #4
Closed with r4083 (after a couple more tweaks discussed verbally).

On 2012/05/30 18:11:48, bsalomon wrote:
> Maybe it should be called "emitGlobalVariables"?

Didn't do this yet because I'm not quite happy with 'emit' here; it seems
qualitatively different from the emitFS()/emitVS() functions which do literally
output code. Here we're setting up structs which glue will later read to drive
an emit.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b