Issue 6259053: Fixed small bug in shader generation

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6259053: Fixed small bug in shader generation (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 5 months ago by robertphillips

Modified:
12 years, 5 months ago

Reviewers:
TomH

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

This bug was adding an extra "* vColor" to the computation of the coverage in the case where dual source blending was being used. The actual color stage (right before the coverage computation) had a modulation and it stuck around for the coverage stage.

Patch Set 1 #

Created: 12 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	M	src/gpu/gl/GrGLShaderBuilder.cpp	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

robertphillips

12 years, 5 months ago (2012-05-30 12:30:57 UTC) #3

committed as r4064.

It was showing up in the xfermodes GM slide when I enabled the SW-only clip mask
generation path for everything. In this case almost everything was being drawn
with a coverage texture so it really exercised the multiple texture stages code.
The xfermodes test is particularly challenging in this scenario since it
exercises the dual blending mode logic. Basically the extra "* vColor" was
making the xfer mode results incorrect (a lot of extra objects showing up when
they shouldn't).

Expand All Messages | Collapse All Messages