Issue 6256061: Proposed fix for http://moinmo.in/MoinMoinBugs/UnderlayPagesCanReceiveAttachments

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6256061: Proposed fix for http://moinmo.in/MoinMoinBugs/UnderlayPagesCanReceiveAttachments

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 6 months ago by eSyr

Modified:
12 years, 6 months ago

Reviewers:
thomas.j.waldmann

Visibility:
Public.

More Reviews

Description

Proposed fix for http://moinmo.in/MoinMoinBugs/UnderlayPagesCanReceiveAttachments

Patch Set 1 #

Total comments: 1

Created: 12 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -1 line)			Patch
	M	MoinMoin/PageEditor.py	View		3 chunks	+3 lines, -1 line	0 comments	Download
	M	MoinMoin/action/AttachFile.py	View		3 chunks	+13 lines, -0 lines	1 comment	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages

ThomasJWaldmann

12 years, 6 months ago (2012-05-28 16:21:12 UTC) #1

http://codereview.appspot.com/6256061/diff/1/MoinMoin/action/AttachFile.py
File MoinMoin/action/AttachFile.py (right):

http://codereview.appspot.com/6256061/diff/1/MoinMoin/action/AttachFile.py#ne...
MoinMoin/action/AttachFile.py:221: 
did you consider just calling copy_underlay_page()?

it might be not really needed to save a new (identical) page text revision just
to trigger that call in _write_file().

if that works, you also do not need to change PageEditor.

Expand All Messages | Collapse All Messages