Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(628)

Issue 6255073: Remove ugly dirty flags from GrGpuGL state flush (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 3 months ago by bsalomon
Modified:
12 years, 3 months ago
Reviewers:
TomH
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Patch Set 1 #

Patch Set 2 : cleanup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -114 lines) Patch
M src/gpu/gl/GrGLProgram.h View 2 chunks +4 lines, -0 lines 0 comments Download
M src/gpu/gl/GrGLProgram.cpp View 1 chunk +3 lines, -0 lines 0 comments Download
M src/gpu/gl/GrGpuGL.h View 2 chunks +2 lines, -25 lines 0 comments Download
M src/gpu/gl/GrGpuGL.cpp View 5 chunks +3 lines, -44 lines 0 comments Download
M src/gpu/gl/GrGpuGL_program.cpp View 1 5 chunks +72 lines, -45 lines 0 comments Download

Messages

Total messages: 3
bsalomon
We have tricky logic that an earlier part of our GL state flush may change ...
12 years, 3 months ago (2012-06-01 15:47:22 UTC) #1
TomH
LGTM?
12 years, 3 months ago (2012-06-01 18:48:40 UTC) #2
bsalomon
12 years, 3 months ago (2012-06-01 19:02:05 UTC) #3
On 2012/06/01 18:48:40, TomH wrote:
> LGTM?

I'll take it, landed r4122.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b