Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(249)

Issue 6251050: Radial Gradients as Custom Shaders (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years ago by TomH
Modified:
13 years ago
Reviewers:
bsalomon
CC:
robertphillips
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Unifies two-point normal and degenerate cases into a single class. I think GrGLRadial2Mapping::GenKey() needs fixing, although this currently passes all our tests. Other areas of concern discussed inline:

Patch Set 1 #

Total comments: 5

Patch Set 2 : Update to setupVariables() API change #

Patch Set 3 : Create SweepMapping stage so we can get rid of CoordMapping enum #

Unified diffs Side-by-side diffs Delta from patch set Stats (+521 lines, -283 lines) Patch
M gyp/gpu.gyp View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
A src/gpu/effects/GrCoordMapping.h View 1 2 1 chunk +93 lines, -0 lines 0 comments Download
A src/gpu/effects/GrCoordMapping.cpp View 1 2 1 chunk +364 lines, -0 lines 0 comments Download
M src/gpu/gl/GrGLProgram.h View 1 2 4 chunks +0 lines, -16 lines 0 comments Download
M src/gpu/gl/GrGLProgram.cpp View 1 2 8 chunks +24 lines, -215 lines 0 comments Download
M src/gpu/gl/GrGLProgramStage.cpp View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/gpu/gl/GrGLShaderBuilder.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/gl/GrGpuGLShaders.cpp View 1 2 9 chunks +37 lines, -50 lines 0 comments Download

Messages

Total messages: 3
TomH
http://codereview.appspot.com/6251050/diff/1/src/gpu/gl/GrGLProgram.cpp File src/gpu/gl/GrGLProgram.cpp (right): http://codereview.appspot.com/6251050/diff/1/src/gpu/gl/GrGLProgram.cpp#newcode1441 src/gpu/gl/GrGLProgram.cpp:1441: // TODO: FIX This *ought* to be straightforward - ...
13 years ago (2012-05-24 20:28:39 UTC) #1
bsalomon
http://codereview.appspot.com/6251050/diff/1/src/gpu/gl/GrGLProgram.cpp File src/gpu/gl/GrGLProgram.cpp (right): http://codereview.appspot.com/6251050/diff/1/src/gpu/gl/GrGLProgram.cpp#newcode1473 src/gpu/gl/GrGLProgram.cpp:1473: SkDEBUGFAIL("Radial Gradients should be handled by custom stages"); GrCrash ...
13 years ago (2012-05-29 19:41:18 UTC) #2
TomH
13 years ago (2012-06-01 20:30:34 UTC) #3
Should be completely obsoleted by http://codereview.appspot.com/6245078/ and
precursors; closing.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b