Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2577)

Issue 6250081: Implementation of all Coord Mappings as GrCustomShaders (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 3 months ago by TomH
Modified:
12 years, 3 months ago
Reviewers:
bsalomon
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Extracted from http://codereview.appspot.com/6251050/, updated to reflect recent commits. I want to separate committing this code from changes that hook these up and were running into refcounting errors, so that the scope of *that* change can be narrower.

Patch Set 1 #

Total comments: 2

Patch Set 2 : Respond to Brian's comments, except for the one I disagree with #

Unified diffs Side-by-side diffs Delta from patch set Stats (+460 lines, -0 lines) Patch
M gyp/gpu.gyp View 1 1 chunk +2 lines, -0 lines 0 comments Download
A src/gpu/effects/GrGradientEffects.h View 1 1 chunk +93 lines, -0 lines 0 comments Download
A src/gpu/effects/GrGradientEffects.cpp View 1 1 chunk +365 lines, -0 lines 0 comments Download

Messages

Total messages: 6
TomH
12 years, 3 months ago (2012-05-31 18:51:34 UTC) #1
bsalomon
Overall looks good. Could we call the files GrGradientEffects (or something like that). I don't ...
12 years, 3 months ago (2012-05-31 19:18:01 UTC) #2
TomH
Renamed files and classes. Added assert, fIsDegenerate member.
12 years, 3 months ago (2012-05-31 19:31:13 UTC) #3
bsalomon
On 2012/05/31 19:31:13, TomH wrote: > Renamed files and classes. > Added assert, fIsDegenerate member. ...
12 years, 3 months ago (2012-05-31 19:37:23 UTC) #4
TomH
Committed in r4104.
12 years, 3 months ago (2012-05-31 19:40:32 UTC) #5
TomH
12 years, 3 months ago (2012-05-31 19:57:49 UTC) #6
On 2012/05/31 19:40:32, TomH wrote:
> Committed in r4104.

... with API fix in r4105.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b