This patch prevents a bogus assertion in debug builds when unflattening a large bitmap object. ...
12 years, 7 months ago
(2012-05-24 21:23:50 UTC)
#1
This patch prevents a bogus assertion in debug builds when unflattening a large
bitmap object. In SkFlatBitmap::unflatten, the size of the readbuffer was
arbitrarily set to 1MB, so images larger that 1MB caused an assertion when
attempting to read past the end of the read buffer.
On 2012/05/25 12:03:13, reed1 wrote: > Derek added the SkOrderedWriteBuffer. I nominate him to review ...
12 years, 7 months ago
(2012-05-29 15:38:33 UTC)
#3
On 2012/05/25 12:03:13, reed1 wrote:
> Derek added the SkOrderedWriteBuffer. I nominate him to review this, as I
think
> he noticed the 1Meg and didn't change it at the time...
LGTM. I have another CL in the works that refactors a lot of this code and has
this exact change in it.
Issue 6250054: Fixing a reader size overflow whenunflattening large bitmaps
(Closed)
Created 12 years, 7 months ago by junov1
Modified 12 years, 6 months ago
Reviewers: DerekS
Base URL: http://skia.googlecode.com/svn/trunk/
Comments: 0