Issue 6250046: asan/tsan: weak interceptors

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6250046: asan/tsan: weak interceptors (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 11 months ago by dvyukov

Modified:
11 years, 8 months ago

Reviewers:
kcc1, glider

Base URL:
https://llvm.org/svn/llvm-project/compiler-rt/trunk/lib/

Visibility:
Public.

Created: 11 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+88 lines, -39 lines)			Patch
M	asan/asan_interceptors.cc	View	3 chunks	+34 lines, -29 lines	0 comments	Download
M	asan/output_tests/heap-overflow.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
A	asan/output_tests/interception_failure_test.cc	View	1 chunk	+17 lines, -0 lines	0 comments	Download
A	asan/output_tests/interception_test.cc	View	1 chunk	+18 lines, -0 lines	0 comments	Download
M	asan/output_tests/use-after-free.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	interception/interception.h	View	3 chunks	+8 lines, -2 lines	0 comments	Download
M	interception/interception_linux.h	View	1 chunk	+4 lines, -2 lines	0 comments	Download
M	interception/interception_linux.cc	View	1 chunk	+3 lines, -2 lines	0 comments	Download
M	tsan/rtl/tsan_rtl_report.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 2

kcc1

Great, thanks! Please add comments after "How it works:" and commit.

11 years, 11 months ago (2012-05-24 12:28:50 UTC) #1

Please make sure that the tests still pass on OS X