Issue 6248071: code review 6248071: cmd/6l: loop alignment, disabled

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6248071: code review 6248071: cmd/6l: loop alignment, disabled (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 10 months ago by rsc

Modified:
11 years, 10 months ago

Reviewers:
ken3

CC:
ken2, golang-dev

Visibility:
Public.

Description

cmd/6l: loop alignment, disabled Saving the code in case we improve things enough that it matters later, but at least right now it is not worth doing.

Patch Set 1 #

Patch Set 2 : diff -r 1a7ca75f2648 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 1a7ca75f2648 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 7131ba57ab5e https://go.googlecode.com/hg/ #

Created: 11 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+62 lines, -1 line)			Patch
M	src/cmd/6l/l.h	View	1 2 3	1 chunk	+17 lines, -0 lines	0 comments	Download
M	src/cmd/6l/span.c	View	1	3 chunks	+44 lines, -1 line	0 comments	Download
M	src/libmach/8db.c	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rsc

Hello ken2 (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

11 years, 10 months ago (2012-06-01 14:23:11 UTC) #1

rsc

*** Submitted as http://code.google.com/p/go/source/detail?r=5eb6fe483779 *** cmd/6l: loop alignment, disabled Saving the code in case we ...

11 years, 10 months ago (2012-06-01 14:23:27 UTC) #2

lgtm

Expand All Messages | Collapse All Messages