Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(264)

Issue 6248060: code review 6248060: dfa_test: Comment out dead variables. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 10 months ago by Stefano Rivera
Modified:
11 years, 10 months ago
Reviewers:
CC:
rsc, re2-dev_googlegroups.com
Visibility:
Public.

Description

dfa_test: Comment out dead variables. GCC 4.6 warns about unused-but-set variables. Comment out variables only used by commented-out code. This commenting-out predates the public re2 hg repo, so no idea who did it or why.

Patch Set 1 #

Patch Set 2 : diff -r 2d252384c5e8 https://re2.googlecode.com/hg #

Patch Set 3 : diff -r 2d252384c5e8 https://re2.googlecode.com/hg #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M re2/testing/dfa_test.cc View 1 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 3
Stefano Rivera
Hello rsc@golang.org (cc: re2-dev@googlegroups.com), I'd like you to review this change to https://re2.googlecode.com/hg
11 years, 10 months ago (2012-05-29 15:20:26 UTC) #1
rsc
*** Submitted as http://code.google.com/p/re2/source/detail?r=c79416ca4228 *** dfa_test: Comment out dead variables. GCC 4.6 warns about unused-but-set ...
11 years, 10 months ago (2012-05-29 15:50:50 UTC) #2
rsc
11 years, 10 months ago (2012-05-29 15:51:12 UTC) #3
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b