Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(376)

Issue 6247055: Control mid-measure beams in 3/4 time; Issue 2566 and 2246 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 10 months ago by Keith
Modified:
11 years, 10 months ago
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Control mid-measure beams in 3/4 time; Issue 2566 and 2246

Patch Set 1 : relative to before original issue 2246 patch #

Patch Set 2 : relative to master #

Total comments: 1

Patch Set 3 : convert-ly #

Total comments: 5
Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -103 lines) Patch
M Documentation/notation/rhythms.itely View 1 2 1 chunk +13 lines, -14 lines 2 comments Download
M input/regression/autobeam-3-4-rules.ly View 1 2 1 chunk +24 lines, -14 lines 1 comment Download
D input/regression/autobeam-start-at-beginning-of-measure-in-3-4.ly View 1 chunk +0 lines, -19 lines 0 comments Download
M input/regression/multiple-time-sig-settings.ly View 1 2 chunks +2 lines, -2 lines 0 comments Download
M ly/engraver-init.ly View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M python/convertrules.py View 1 2 1 chunk +7 lines, -0 lines 0 comments Download
M scm/auto-beam.scm View 1 2 4 chunks +14 lines, -41 lines 2 comments Download
M scm/define-context-properties.scm View 1 2 1 chunk +2 lines, -4 lines 0 comments Download
M scm/time-signature-settings.scm View 1 1 chunk +6 lines, -7 lines 0 comments Download

Messages

Total messages: 4
Keith
http://codereview.appspot.com/6247055/diff/4001/scm/auto-beam.scm File scm/auto-beam.scm (right): http://codereview.appspot.com/6247055/diff/4001/scm/auto-beam.scm#newcode109 scm/auto-beam.scm:109: (if (= dir START) Maybe it would read more ...
11 years, 10 months ago (2012-05-28 19:43:40 UTC) #1
Trevor Daniels
LGTM, apart from one query. Trevor http://codereview.appspot.com/6247055/diff/9002/scm/auto-beam.scm File scm/auto-beam.scm (right): http://codereview.appspot.com/6247055/diff/9002/scm/auto-beam.scm#newcode115 scm/auto-beam.scm:115: (* 2 (cdr ...
11 years, 10 months ago (2012-05-29 17:38:26 UTC) #2
Keith
http://codereview.appspot.com/6247055/diff/9002/Documentation/notation/rhythms.itely File Documentation/notation/rhythms.itely (right): http://codereview.appspot.com/6247055/diff/9002/Documentation/notation/rhythms.itely#newcode2168 Documentation/notation/rhythms.itely:2168: (see Gould, p. 153). Added "Similar situations arise in ...
11 years, 10 months ago (2012-05-29 18:01:08 UTC) #3
Neil Puttock
11 years, 10 months ago (2012-05-31 21:12:38 UTC) #4
LGTM.

http://codereview.appspot.com/6247055/diff/9002/input/regression/autobeam-3-4...
File input/regression/autobeam-3-4-rules.ly (right):

http://codereview.appspot.com/6247055/diff/9002/input/regression/autobeam-3-4...
input/regression/autobeam-3-4-rules.ly:17: \set Timing.beamHalfMeasure = ##f
This property doesn't seem to be documented as read by the Auto_beam_engraver. 
An entry in lily/auto-beam-engraver.cc would be nice.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b