Issue 6245083: Move GrGpuGL::ProgramCache declaration to header

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6245083: Move GrGpuGL::ProgramCache declaration to header (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years ago by bsalomon

Modified:
13 years ago

Reviewers:
TomH

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

Created: 13 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+103 lines, -107 lines)			Patch
M	src/gpu/gl/GrGpuGL.h	View	3 chunks	+42 lines, -4 lines	0 comments	Download
M	src/gpu/gl/GrGpuGL.cpp	View	2 chunks	+5 lines, -2 lines	0 comments	Download
M	src/gpu/gl/GrGpuGL_program.cpp	View	3 chunks	+56 lines, -101 lines	0 comments	Download

Total messages: 3

bsalomon

Currently no functions in GrGpuGL.cpp can directly interact with the cache since it is declared ...

13 years ago (2012-06-01 14:59:27 UTC) #1

TomH

Good! This was one of those places I took "trust the implementor" too far in ...

13 years ago (2012-06-01 15:00:54 UTC) #2

Landed r4113.