Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(192)

Issue 6245076: Merge GrGpuGLShaders into its parent class, GrGpuGL (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 6 months ago by bsalomon
Modified:
12 years, 6 months ago
Reviewers:
robertphillips, TomH
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Patch Set 1 #

Patch Set 2 : remove unrelated gyp change #

Patch Set 3 : delete old header #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+174 lines, -1437 lines) Patch
M gyp/gpu.gyp View 1 1 chunk +2 lines, -2 lines 2 comments Download
M src/gpu/GrGpuFactory.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/gl/GrGLProgram.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/gl/GrGpuGL.h View 5 chunks +69 lines, -1 line 2 comments Download
M src/gpu/gl/GrGpuGL.cpp View 3 chunks +61 lines, -0 lines 0 comments Download
M src/gpu/gl/GrGpuGLShaders.h View 1 2 1 chunk +0 lines, -98 lines 0 comments Download
D src/gpu/gl/GrGpuGLShaders.cpp View 1 chunk +0 lines, -1235 lines 0 comments Download
A + src/gpu/gl/GrGpuGL_program.cpp View 19 chunks +37 lines, -96 lines 0 comments Download
M tests/GLProgramsTest.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5
bsalomon
The time has come! Once upon a time we had a fixed pipe implementation and ...
12 years, 6 months ago (2012-05-31 14:20:30 UTC) #1
TomH
LGTM http://codereview.appspot.com/6245076/diff/4001/gyp/gpu.gyp File gyp/gpu.gyp (right): http://codereview.appspot.com/6245076/diff/4001/gyp/gpu.gyp#newcode314 gyp/gpu.gyp:314: '../src/gpu/gl/GrGpuGL.cpp', This file appears twice? http://codereview.appspot.com/6245076/diff/4001/src/gpu/gl/GrGpuGL.h File src/gpu/gl/GrGpuGL.h ...
12 years, 6 months ago (2012-05-31 14:32:43 UTC) #2
bsalomon
http://codereview.appspot.com/6245076/diff/4001/gyp/gpu.gyp File gyp/gpu.gyp (right): http://codereview.appspot.com/6245076/diff/4001/gyp/gpu.gyp#newcode314 gyp/gpu.gyp:314: '../src/gpu/gl/GrGpuGL.cpp', On 2012/05/31 14:32:43, TomH wrote: > This file ...
12 years, 6 months ago (2012-05-31 14:36:06 UTC) #3
robertphillips
LGTM
12 years, 6 months ago (2012-05-31 15:03:07 UTC) #4
bsalomon
12 years, 6 months ago (2012-05-31 20:53:12 UTC) #5
On 2012/05/31 15:03:07, robertphillips wrote:
> LGTM

Committed r4095.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b