Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(478)

Issue 6243070: cmd: add jujut (juju testing) (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 6 months ago by dave
Modified:
12 years, 6 months ago
Reviewers:
niemeyer, fwereade, mp+107902
Visibility:
Public.

Description

cmd: add jujut (juju testing) jujut is a small tool I wrote to push values into the state to test the provisioning agent. It doesn't replace unit tests and is not intended to be shipped to customers. It has value for me, and if accepted, I expect to be replaced at some point when we have jujuc working. https://code.launchpad.net/~dave-cheney/juju/go-command-jujut/+merge/107902 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : cmd: add jujut (juju testing) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+225 lines, -0 lines) Patch
A [revision details] View 1 1 chunk +2 lines, -0 lines 0 comments Download
A cmd/jujut/add_machine.go View 1 chunk +41 lines, -0 lines 0 comments Download
A cmd/jujut/agent.go View 1 chunk +70 lines, -0 lines 0 comments Download
A cmd/jujut/main.go View 1 chunk +16 lines, -0 lines 0 comments Download
A cmd/jujut/remove_machine.go View 1 chunk +45 lines, -0 lines 0 comments Download
A cmd/jujut/setup_dummy.go View 1 chunk +46 lines, -0 lines 0 comments Download
M state/state.go View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 6
dave_cheney.net
Please take a look.
12 years, 6 months ago (2012-05-30 01:44:49 UTC) #1
fwereade
I'm -1 on this at the moment... it seems to have a fair amount of ...
12 years, 6 months ago (2012-05-30 07:04:29 UTC) #2
dave_cheney.net
I used these commands while testing the PA, I thought they might be useful for ...
12 years, 6 months ago (2012-05-30 07:12:17 UTC) #3
dave_cheney.net
Please take a look.
12 years, 6 months ago (2012-06-01 06:43:11 UTC) #4
niemeyer
I agree with William. Even without seeing his comments, we had already debated about the ...
12 years, 6 months ago (2012-06-06 12:22:46 UTC) #5
dave_cheney.net
12 years, 6 months ago (2012-06-06 12:31:42 UTC) #6
Sounds fair, i'll put this code on ice until we need them for juju cli.

On Wed, Jun 6, 2012 at 10:22 PM,  <n13m3y3r@gmail.com> wrote:
> I agree with William. Even without seeing his comments, we had already
> debated about the low level of automated testing in the provisioning
> agent. The use of this tool is a side effect of doing one-off tests
> manually rather than introducing proper logic onto the tests that
> continue to be run after it is integrated.
>
> From another perspective, some of these commands should be actual
> commands of juju. add-machine and remove-machine are two great
> candidates for living on the real command line suite.
>
> https://codereview.appspot.com/6243070/
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b