Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(854)

Issue 6242051: Move non-overridable functions onto GrGLShaderBuilder (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 1 month ago by TomH
Modified:
12 years, 1 month ago
Reviewers:
bsalomon
CC:
robertphillips
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Also moves swizzle & modulation computation / storage. Now everything on GrGLProgramStage is virtual with no (or an empty) default implementation. Open questions: Should the kMulByAlphaMask fetches be a GrCustomStage? Or should we glom those onto emitDefaultFetch()? I assume the former. Next steps: mappings, then texture domains & choosing texture functions.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+163 lines, -146 lines) Patch
M src/gpu/effects/GrConvolutionEffect.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/gl/GrGLProgram.cpp View 8 chunks +30 lines, -56 lines 0 comments Download
M src/gpu/gl/GrGLProgramStage.h View 1 chunk +0 lines, -33 lines 0 comments Download
M src/gpu/gl/GrGLProgramStage.cpp View 1 chunk +0 lines, -52 lines 0 comments Download
M src/gpu/gl/GrGLShaderBuilder.h View 2 chunks +46 lines, -4 lines 0 comments Download
M src/gpu/gl/GrGLShaderBuilder.cpp View 3 chunks +86 lines, -0 lines 0 comments Download

Messages

Total messages: 3
TomH
12 years, 1 month ago (2012-05-24 17:03:24 UTC) #1
bsalomon
On 2012/05/24 17:03:24, TomH wrote: LGTM I think it is ok for mul by alpha ...
12 years, 1 month ago (2012-05-24 17:40:00 UTC) #2
TomH
12 years, 1 month ago (2012-05-24 17:54:26 UTC) #3
Committed with r4045.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b