Fix handling of 'target' attributes

Fixes http://code.google.com/p/google-caja/issues/detail?id=1471

This change required passing an out-of-band "this attribute was
unspecified by the guest programmer" signal from TemplateCompiler to
HtmlAttributeRewriter. See changes for details of how this is done.

[felix8a, 2012-05-23 21:52:20]

what if I say <a target> or <a target=> ?
does this do the right thing?

[ihab.awad, 2012-05-23 22:53:58]

> <a target>

Added a test.

> <a target=>

FATAL_ERROR in the server side cajoler.

[felix8a, 2012-05-23 23:52:34]

On 2012/05/23 22:53:58, ihab.awad wrote:
> > <a target=>
> 
> FATAL_ERROR in the server side cajoler.

that seems wrong.  the cajoler currently doesn't complain about that, and I can
find many instances of people writing target="", though it's not clear to me
what the intent of that is.

[ihab.awad, 2012-05-23 23:55:06]

(target="") !== (target=)

I verified in the playground. What makes you think the cajoler doesn't
complain?

On Wed, May 23, 2012 at 4:52 PM, <felix8a@gmail.com> wrote:

> On 2012/05/23 22:53:58, ihab.awad wrote:
>
>> > <a target=>
>>
>
>  FATAL_ERROR in the server side cajoler.
>>
>
> that seems wrong.  the cajoler currently doesn't complain about that,
> and I can find many instances of people writing target="", though it's
> not clear to me what the intent of that is.
>
>
http://codereview.appspot.com/**6240043/<http://codereview.appspot.com/6240043/>
>



-- 
Ihab A.B. Awad, Palo Alto, CA

[felix8a, 2012-05-23 23:59:21]

On Wed, May 23, 2012 at 4:55 PM, <ihab.awad@gmail.com> wrote:

> (target="") !== (target=)
>
> I verified in the playground. What makes you think the cajoler doesn't
> complain?
>

I tried
  ​<a target=>hi</a>
at caja.appspot.com and it worked for me.

[ihab.awad, 2012-05-24 00:11:57]

On Wed, May 23, 2012 at 4:59 PM, felix <felix8a@gmail.com> wrote:

> I tried
>   ​<a target=>hi</a>
> at caja.appspot.com and it worked for me.
>

Oh weird. It worked for me too. What did *not* work for me was:

​<a target= href="http://www.google.com/">hi</a>



and it complained with:

FATAL_ERROR unknown:///unknown:0+0: malformed xhtml: "http://www.google.com/
":
unknown:///unknown:0 <http://caja.appspot.com/?es5=false#>: <a target=
href="http://www.google.com/">hi</a>


so it seems it parses the "href=..." as the possible value of the "target"
attribute. Fwiw, the following does work (again, as with your case
"target=" is the last thing inside the angle brackets):


<a href="http://www.google.com/" target=>hi</a>



Ok, I'll add your case to the tests and resend.

Ihab

-- 
Ihab A.B. Awad, Palo Alto, CA

[felix8a, 2012-05-24 00:14:30]

On Wed, May 23, 2012 at 5:11 PM, <ihab.awad@gmail.com> wrote:

>
> On Wed, May 23, 2012 at 4:59 PM, felix <felix8a@gmail.com> wrote:
>
>> I tried
>>   ​<a target=>hi</a>
>> at caja.appspot.com and it worked for me.
>>
>
> Oh weird. It worked for me too. What did *not* work for me was:
>
> ​<a target= href="http://www.google.com/">hi</a>
>
>
>
> and it complained with:
>
> FATAL_ERROR unknown:///unknown:0+0: malformed xhtml: "
> http://www.google.com/":
> unknown:///unknown:0 <http://caja.appspot.com/?es5=false#>: <a target=
> href="http://www.google.com/">hi</a>
>
>
ah, yeah, iirc that's a weirdness with variant html parsing by old
browsers, which should be mostly irrelevant now, and caja is being weird
about what it accepts.

[ihab.awad, 2012-05-24 00:17:38]

Test added per discussion.

[felix8a, 2012-05-24 00:21:17]

one nit, and lgtm

http://codereview.appspot.com/6240043/diff/10002/src/com/google/caja/plugin/t...
File src/com/google/caja/plugin/templates/HtmlAttributeRewriter.java (right):

http://codereview.appspot.com/6240043/diff/10002/src/com/google/caja/plugin/t...
src/com/google/caja/plugin/templates/HtmlAttributeRewriter.java:366: return
(Expression) QuasiBuilder.substV(""
fix indentation

[felix8a, 2012-05-24 02:03:09]

still lgtm

[ihab.awad, 2012-05-24 02:09:05]

@4887