Issue 6239043: Infrastructure for RadialMapping stages

Issue 6239043: Infrastructure for RadialMapping stages (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 4 months ago by TomH

Modified:
12 years, 4 months ago

Reviewers:
bsalomon, robertphillips

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

Description

I'll go ahead and double-check that I can get the radial mappings working off of this basis: only one custom stage per shader stage.

Patch Set 2 : Cache my own data, bless its heart. #

Patch Set 3 : Farewell, cruel sampler states. #

Total comments: 2

Created: 12 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+149 lines, -110 lines)			Patch
M	src/gpu/effects/GrConvolutionEffect.cpp	View		6 chunks	+23 lines, -16 lines	0 comments	Download
M	src/gpu/gl/GrGLProgram.cpp	View		5 chunks	+76 lines, -74 lines	0 comments	Download
M	src/gpu/gl/GrGLProgramStage.h	View	1 2	6 chunks	+27 lines, -17 lines	2 comments	Download
M	src/gpu/gl/GrGLProgramStage.cpp	View	1 2	2 chunks	+21 lines, -2 lines	0 comments	Download
M	src/gpu/gl/GrGpuGLShaders.cpp	View		1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 7

Expand All Messages | Collapse All Messages

bsalomon

http://codereview.appspot.com/6239043/diff/1/src/gpu/gl/GrGLProgramStage.h File src/gpu/gl/GrGLProgramStage.h (right): http://codereview.appspot.com/6239043/diff/1/src/gpu/gl/GrGLProgramStage.h#newcode72 src/gpu/gl/GrGLProgramStage.h:72: /** Appends fragment code to the appropriate GrStrongBuilder Strong->String ...

12 years, 4 months ago (2012-05-23 20:25:53 UTC) #3

TomH

12 years, 4 months ago (2012-05-23 20:34:42 UTC) #4

robertphillips

LGTM + 1 nit http://codereview.appspot.com/6239043/diff/3007/src/gpu/gl/GrGLProgramStage.h File src/gpu/gl/GrGLProgramStage.h (right): http://codereview.appspot.com/6239043/diff/3007/src/gpu/gl/GrGLProgramStage.h#newcode94 src/gpu/gl/GrGLProgramStage.h:94: virtual void setData(const GrGLInterface*, parameter ...

12 years, 4 months ago (2012-05-23 21:21:22 UTC) #5

TomH

12 years, 4 months ago (2012-05-24 15:10:48 UTC) #7

Closed with r4040.

http://codereview.appspot.com/6239043/diff/3007/src/gpu/gl/GrGLProgramStage.h
File src/gpu/gl/GrGLProgramStage.h (right):

http://codereview.appspot.com/6239043/diff/3007/src/gpu/gl/GrGLProgramStage.h...
src/gpu/gl/GrGLProgramStage.h:94: virtual void setData(const GrGLInterface*,
On 2012/05/23 21:21:22, robertphillips wrote:
> parameter names? Everyone else has them.

Done.

Expand All Messages | Collapse All Messages