Issue 6235044: [http #104] HttpHeaders: need case insensitive get, set, and put

Issue 6235044: [http #104] HttpHeaders: need case insensitive get, set, and put (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 11 months ago by yanivi

Modified:
11 years, 11 months ago

Reviewers:
mlinder

CC:
rmistry

Base URL:
https://google-http-java-client.googlecode.com/hg/

Visibility:
Public.

Patch Set 2 : ready for review #

Total comments: 4

Patch Set 3 : GenericData.Flags #

Created: 11 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+291 lines, -74 lines)			Patch
M	google-http-client/src/main/java/com/google/api/client/http/HttpHeaders.java	View	1 2	6 chunks	+16 lines, -20 lines	0 comments	Download
M	google-http-client/src/main/java/com/google/api/client/http/HttpResponse.java	View		4 chunks	+4 lines, -10 lines	0 comments	Download
M	google-http-client/src/main/java/com/google/api/client/util/ClassInfo.java	View	1	7 chunks	+56 lines, -11 lines	0 comments	Download
M	google-http-client/src/main/java/com/google/api/client/util/Data.java	View		2 chunks	+3 lines, -2 lines	0 comments	Download
M	google-http-client/src/main/java/com/google/api/client/util/DataMap.java	View		2 chunks	+7 lines, -3 lines	0 comments	Download
M	google-http-client/src/main/java/com/google/api/client/util/GenericData.java	View	1 2	6 chunks	+64 lines, -16 lines	0 comments	Download
M	google-http-client/src/test/java/com/google/api/client/http/HttpHeadersTest.java	View		3 chunks	+2 lines, -2 lines	0 comments	Download
M	google-http-client/src/test/java/com/google/api/client/http/HttpRequestTest.java	View	1	2 chunks	+10 lines, -1 line	0 comments	Download
M	google-http-client/src/test/java/com/google/api/client/util/ClassInfoTest.java	View	1	2 chunks	+30 lines, -2 lines	0 comments	Download
M	google-http-client/src/test/java/com/google/api/client/util/DataMapTest.java	View		7 chunks	+7 lines, -7 lines	0 comments	Download
M	google-http-client/src/test/java/com/google/api/client/util/GenericDataTest.java	View	1 2	2 chunks	+92 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

mlinder

LGTM http://codereview.appspot.com/6235044/diff/2001/google-http-client/src/main/java/com/google/api/client/http/HttpHeaders.java File google-http-client/src/main/java/com/google/api/client/http/HttpHeaders.java (right): http://codereview.appspot.com/6235044/diff/2001/google-http-client/src/main/java/com/google/api/client/http/HttpHeaders.java#newcode51 google-http-client/src/main/java/com/google/api/client/http/HttpHeaders.java:51: super(true); Suggestion -- Make it something like: super(true); ...

11 years, 11 months ago (2012-05-24 14:10:24 UTC) #2

yanivi

11 years, 11 months ago (2012-05-24 17:17:04 UTC) #3

Submitting now...

http://codereview.appspot.com/6235044/diff/2001/google-http-client/src/main/j...
File
google-http-client/src/main/java/com/google/api/client/http/HttpHeaders.java
(right):

http://codereview.appspot.com/6235044/diff/2001/google-http-client/src/main/j...
google-http-client/src/main/java/com/google/api/client/http/HttpHeaders.java:51:
super(true);
On 2012/05/24 14:10:24, Matthias wrote:
> Suggestion -- Make it something like:
> super(true); // GenericData with case-sensitivity disabled

Done.

http://codereview.appspot.com/6235044/diff/2001/google-http-client/src/main/j...
File
google-http-client/src/main/java/com/google/api/client/util/GenericData.java
(right):

http://codereview.appspot.com/6235044/diff/2001/google-http-client/src/main/j...
google-http-client/src/main/java/com/google/api/client/util/GenericData.java:67:
public GenericData(boolean ignoreCase) {
On 2012/05/24 14:10:24, Matthias wrote:
> consider making this a bit-flag enum instead of a bool as a bool is pretty
much
> unreadable. Another plus of an enum: It is easier to add new features in the
> future.

Done.

Expand All Messages | Collapse All Messages