Kill GrGpuGL::fHWDrawState

[bsalomon, 2012-05-21 21:50:06]

http://codereview.appspot.com/6227048/diff/1/src/gpu/gl/GrGpuGLShaders.cpp
File src/gpu/gl/GrGpuGLShaders.cpp (left):

http://codereview.appspot.com/6227048/diff/1/src/gpu/gl/GrGpuGLShaders.cpp#ol...
src/gpu/gl/GrGpuGLShaders.cpp:706:
fHWDrawState.setViewMatrix(GrMatrix::InvalidMatrix());
This should have been removed when I removed the option to specify matrices as
vertex attribs. Below we invalidate the per-program matrices.

[robertphillips, 2012-05-21 21:59:03]

LGTM

[TomH, 2012-05-21 22:02:38]

LGTM modulo nit:

http://codereview.appspot.com/6227048/diff/1/src/gpu/gl/GrGpuGL.h
File src/gpu/gl/GrGpuGL.h (right):

http://codereview.appspot.com/6227048/diff/1/src/gpu/gl/GrGpuGL.h#newcode77
src/gpu/gl/GrGpuGL.h:77: // its flush is complete.
I don't think I understand any of this comment, but the first sentence is
particularly opaque with its choice of verb tense.

[bsalomon, 2012-05-21 22:14:01]

http://codereview.appspot.com/6227048/diff/1/src/gpu/gl/GrGpuGL.h
File src/gpu/gl/GrGpuGL.h (right):

http://codereview.appspot.com/6227048/diff/1/src/gpu/gl/GrGpuGL.h#newcode77
src/gpu/gl/GrGpuGL.h:77: // its flush is complete.
On 2012/05/21 22:02:38, TomH wrote:
> I don't think I understand any of this comment, but the first sentence is
> particularly opaque with its choice of verb tense.

Hopefully this is clearer:

    // The current render target and textures are bound by GrGpuGL when it
    // flushes state to GL. After the bindings occur the variables that track
    // the current GL state are updated to reflect the new bindings. However,
    // the GrGpuGL subclass may have subsequent GL state manipulation it must
    // perform whenever RT or textures change. So the GrGpuGL will set these
    // dirty flags when it changes the RT or texture bindings. The subclass can
    // use them to trigger its dependent state flushing. The subclass should
    // call resetDirtyFlags to zero these out after it has consumed them.
    //
    // TODO: Merge GrGpuGLShaders into GrGpuGL and remove the need for these
    // flags.

[bsalomon, 2012-05-21 22:16:17]

Closed with r4024.