Issue 6222052: When GL context is reset set some desktop-only GL state to values that we assume

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6222052: When GL context is reset set some desktop-only GL state to values that we assume (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 1 month ago by bsalomon

Modified:
13 years, 1 month ago

Reviewers:
robertphillips, TomH

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

Patch Set 2 : update #

Total comments: 2

Created: 13 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+23 lines, -4 lines)			Patch
	M	src/gpu/gl/GrGLDefines.h	View	1	1 chunk	+8 lines, -0 lines	1 comment	Download
	M	src/gpu/gl/GrGpuGL.cpp	View	1	2 chunks	+15 lines, -4 lines	1 comment	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

bsalomon

http://codereview.appspot.com/6222052/diff/2001/src/gpu/gl/GrGpuGL.cpp File src/gpu/gl/GrGpuGL.cpp (left): http://codereview.appspot.com/6222052/diff/2001/src/gpu/gl/GrGpuGL.cpp#oldcode510 src/gpu/gl/GrGpuGL.cpp:510: GL_CALL(ColorMask(GR_GL_TRUE, GR_GL_TRUE, GR_GL_TRUE, GR_GL_TRUE)); Accidentally omitted this deletion from ...

13 years, 1 month ago (2012-05-21 17:38:47 UTC) #1

TomH

LGTM http://codereview.appspot.com/6222052/diff/2001/src/gpu/gl/GrGLDefines.h File src/gpu/gl/GrGLDefines.h (right): http://codereview.appspot.com/6222052/diff/2001/src/gpu/gl/GrGLDefines.h#newcode139 src/gpu/gl/GrGLDefines.h:139: #define GR_GL_LINE_STIPPLE 0x0B24 Is this an append-only list? ...

13 years, 1 month ago (2012-05-21 17:56:17 UTC) #3

bsalomon

13 years, 1 month ago (2012-05-21 20:15:45 UTC) #4

On 2012/05/21 17:56:17, TomH wrote:
> LGTM
> 
> http://codereview.appspot.com/6222052/diff/2001/src/gpu/gl/GrGLDefines.h
> File src/gpu/gl/GrGLDefines.h (right):
> 
>
http://codereview.appspot.com/6222052/diff/2001/src/gpu/gl/GrGLDefines.h#newc...
> src/gpu/gl/GrGLDefines.h:139: #define GR_GL_LINE_STIPPLE                  
> 0x0B24
> Is this an append-only list? Would it ever be worth sorting?

I'd say sort the whole file. I don't think we get much out of the
categorization. It's not GL reference guide.

Committed as r4018.

Expand All Messages | Collapse All Messages