This is somewhat a tangent from the previous changes. The msaa/smooth line tracking was already ...
12 years, 3 months ago
(2012-05-21 15:50:44 UTC)
#1
This is somewhat a tangent from the previous changes. The msaa/smooth line
tracking was already done outside fHWDrawState. This change uses the newly added
TriState rather than bools to take advantage of the unknown value.
It also fixes the following bug. Line smoothing state in desktop GL is ignored
if MSAA is enabled. However, we were disabling MSAA for all lines, even when we
couldn't use the line smoothing.
http://codereview.appspot.com/6222051/diff/1/src/gpu/gl/GrGpuGL.cpp
File src/gpu/gl/GrGpuGL.cpp (left):
http://codereview.appspot.com/6222051/diff/1/src/gpu/gl/GrGpuGL.cpp#oldcode1944
src/gpu/gl/GrGpuGL.cpp:1944: GL_CALL(Disable(GR_GL_MULTISAMPLE));
The bug was here. We're disabling MSAA for all lines, smooth or not.
LGTM http://codereview.appspot.com/6222051/diff/1/src/gpu/gl/GrGpuGL.cpp File src/gpu/gl/GrGpuGL.cpp (right): http://codereview.appspot.com/6222051/diff/1/src/gpu/gl/GrGpuGL.cpp#newcode468 src/gpu/gl/GrGpuGL.cpp:468: // should we also disable polygon smoothing? I ...
12 years, 3 months ago
(2012-05-21 16:33:24 UTC)
#2
LGTM http://codereview.appspot.com/6222051/diff/1/src/gpu/gl/GrGpuGL.cpp File src/gpu/gl/GrGpuGL.cpp (right): http://codereview.appspot.com/6222051/diff/1/src/gpu/gl/GrGpuGL.cpp#newcode468 src/gpu/gl/GrGpuGL.cpp:468: // should we also disable polygon smoothing? On ...
12 years, 3 months ago
(2012-05-21 16:35:21 UTC)
#3
Issue 6222051: Use tristate in HW AA tracking, fix msaa disabled for non-smoothed lines bug
(Closed)
Created 12 years, 3 months ago by bsalomon
Modified 12 years, 3 months ago
Reviewers: TomH, robertphillips
Base URL: http://skia.googlecode.com/svn/trunk/
Comments: 3