Issue 6222049: code review 6222049: libmach: Fixed build problem.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6222049: code review 6222049: libmach: Fixed build problem.

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 7 months ago by MariusHillenbrand

Modified:
11 years, 3 months ago

Reviewers:
npe

CC:
nix-dev_googlegroups.com

Visibility:
Public.

Description

libmach: Fixed build problem. mkfile in sys/src/libmach required 9c, which is not available in 9vx. A building code tree is a happy code tree.

Patch Set 1 #

Patch Set 2 : diff -r e3554a6a8a16 https://code.google.com/p/nix-os/ #

Patch Set 3 : diff -r e3554a6a8a16 https://code.google.com/p/nix-os/ #

Patch Set 4 : diff -r e3554a6a8a16 https://code.google.com/p/nix-os/ #

Patch Set 5 : diff -r e3554a6a8a16 https://code.google.com/p/nix-os/ #

Patch Set 6 : diff -r e3554a6a8a16 https://code.google.com/p/nix-os/ #

Patch Set 7 : diff -r e3554a6a8a16 https://code.google.com/p/nix-os/ #

Patch Set 8 : diff -r e3554a6a8a16 https://code.google.com/p/nix-os/ #

Patch Set 9 : diff -r e3554a6a8a16 https://code.google.com/p/nix-os/ #

Created: 13 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -1 line)			Patch
	M	sys/src/libmach/mkfile	View	1	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

MariusHillenbrand

Hello noah.evans@gmail.com (cc: nix-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/nix-os/

13 years, 7 months ago (2012-05-21 09:21:28 UTC) #1

npe

13 years, 7 months ago (2012-05-21 10:31:45 UTC) #2

LGTM

Noah


On Mon, May 21, 2012 at 11:21 AM,  <MariusHillenbrand@googlemail.com> wrote:
> Reviewers: npe,
>
> Message:
> Hello noah.evans@gmail.com (cc: nix-dev@googlegroups.com),
>
> I'd like you to review this change to
> https://code.google.com/p/nix-os/
>
>
> Description:
> libmach: Fixed build problem.
> mkfile in sys/src/libmach required 9c, which is
> not available in 9vx.
> A building code tree is a happy code tree.
>
> Please review this at http://codereview.appspot.com/6222049/
>
> Affected files:
>  M sys/src/libmach/mkfile
>
>
> Index: sys/src/libmach/mkfile
> ===================================================================
> --- a/sys/src/libmach/mkfile
> +++ b/sys/src/libmach/mkfile
> @@ -61,7 +61,6 @@
>  6obj.$O: /sys/src/cmd/6c/6.out.h
>  7obj.$O: /sys/src/cmd/7c/7.out.h
>  8obj.$O: /sys/src/cmd/8c/8.out.h
> -9obj.$O: /sys/src/cmd/9c/9.out.h
>  kobj.$O: /sys/src/cmd/kc/k.out.h
>  qobj.$O: /sys/src/cmd/qc/q.out.h
>  uobj.$O: uc/u.out.h
>
>

Expand All Messages | Collapse All Messages