Remove SoftwarePathRenderer from GrContext's path renderer chain

Next step in refactoring SW-only clip mask creation logic (i.e., useSWOnlyPath)

[bsalomon, 2012-05-23 12:35:21]

LGTM, you an choose whether to pay attention to any my nits or not.

http://codereview.appspot.com/6221065/diff/1/src/gpu/GrContext.cpp
File src/gpu/GrContext.cpp (right):

http://codereview.appspot.com/6221065/diff/1/src/gpu/GrContext.cpp#newcode1938
src/gpu/GrContext.cpp:1938: if (NULL == fSoftwarePathRenderer) {
very minor, but should we put this in the if below? No need to create it if we
never need it.

http://codereview.appspot.com/6221065/diff/1/src/gpu/GrContext.cpp#newcode1947
src/gpu/GrContext.cpp:1947: return fSoftwarePathRenderer;
nit: I'd find this slightly easier to parse if it were

if (...) {
 return fSWPR;
} else {
 return pr;
}

or


if (...) {
 pr = fSWPR;
}

return pr;

http://codereview.appspot.com/6221065/diff/1/src/gpu/GrContext.cpp#newcode2010
src/gpu/GrContext.cpp:2010: : fPathRendererChain(NULL)
nit: why are these singled out for being initialized differently then everything
else? I don't really have a pref for init lists or not (and find the ordering
warnings particularly annoying for POD members), but this seems a bit arbitrary.

[robertphillips, 2012-05-23 13:19:51]

committed as r4036

http://codereview.appspot.com/6221065/diff/1/src/gpu/GrContext.cpp
File src/gpu/GrContext.cpp (right):

http://codereview.appspot.com/6221065/diff/1/src/gpu/GrContext.cpp#newcode1938
src/gpu/GrContext.cpp:1938: if (NULL == fSoftwarePathRenderer) {
On 2012/05/23 12:35:21, bsalomon wrote:
> very minor, but should we put this in the if below? No need to create it if we
> never need it. 

Done.

http://codereview.appspot.com/6221065/diff/1/src/gpu/GrContext.cpp#newcode1947
src/gpu/GrContext.cpp:1947: return fSoftwarePathRenderer;
Done - used second variant.

http://codereview.appspot.com/6221065/diff/1/src/gpu/GrContext.cpp#newcode2010
src/gpu/GrContext.cpp:2010: : fPathRendererChain(NULL)
On 2012/05/23 12:35:21, bsalomon wrote:
> nit: why are these singled out for being initialized differently then
everything
> else? I don't really have a pref for init lists or not (and find the ordering
> warnings particularly annoying for POD members), but this seems a bit
arbitrary.
> 

Done.